From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-3.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1VvQ2H-00031A-N2 for ltp-list@lists.sourceforge.net; Tue, 24 Dec 2013 11:20:29 +0000 Received: from mx4-phx2.redhat.com ([209.132.183.25]) by sog-mx-4.v43.ch3.sourceforge.com with esmtp (Exim 4.76) id 1VvQ2G-0002hs-9l for ltp-list@lists.sourceforge.net; Tue, 24 Dec 2013 11:20:29 +0000 Date: Tue, 24 Dec 2013 06:20:19 -0500 (EST) From: Jan Stancek Message-ID: <1047061580.9198618.1387884019826.JavaMail.root@redhat.com> In-Reply-To: <52B960D4.5050506@cn.fujitsu.com> References: <52B960D4.5050506@cn.fujitsu.com> MIME-Version: 1.0 Subject: Re: [LTP] [PATCH] semop/semop04.c: fix a bug when running with -i option List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Xiaoguang Wang Cc: ltp-list@lists.sourceforge.net ----- Original Message ----- > From: "Xiaoguang Wang" > To: ltp-list@lists.sourceforge.net > Sent: Tuesday, 24 December, 2013 11:24:20 AM > Subject: [LTP] [PATCH] semop/semop04.c: fix a bug when running with -i option > > If we run semop04 like this: ./semop04 -i 2, > its output will be: > > semop04 1 TPASS : expected failure - errno = 11 : Resource temporarily > unavailable > semop04 2 TPASS : expected failure - errno = 11 : Resource temporarily > unavailable > semop04 1 TBROK : semctl() failed > semop04 2 TBROK : Remaining cases broken. > > Actually in the second iteration, semctl will return ERANGE. This is > because the val variable will be less than zero in the sceond iteration. > > Variable val should be reset to 1 before this actual errno test. > > Signed-off-by: Xiaoguang Wang Looks good: Reviewed-by: Jan Stancek > --- > testcases/kernel/syscalls/ipc/semop/semop04.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/testcases/kernel/syscalls/ipc/semop/semop04.c > b/testcases/kernel/syscalls/ipc/semop/semop04.c > index 2725378..f7efd86 100644 > --- a/testcases/kernel/syscalls/ipc/semop/semop04.c > +++ b/testcases/kernel/syscalls/ipc/semop/semop04.c > @@ -80,7 +80,7 @@ int main(int ac, char **av) > { > int lc; > char *msg; > - int val = 1; /* value for SETVAL */ > + int val; /* value for SETVAL */ > > int i; > > @@ -96,6 +96,7 @@ int main(int ac, char **av) > /* reset tst_count in case we are looping */ > tst_count = 0; > > + val = 1; > for (i = 0; i < TST_TOTAL; i++) { > > /* initialize the s_buf buffer */ > -- > 1.8.2.1 > > > ------------------------------------------------------------------------------ > Rapidly troubleshoot problems before they affect your business. Most IT > organizations don't have a clear picture of how application performance > affects their revenue. With AppDynamics, you get 100% visibility into your > Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics > Pro! > http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk > _______________________________________________ > Ltp-list mailing list > Ltp-list@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ltp-list > ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list