[LTP] [RFC] [PATCH] pselect01: Tune thresholds

Cyril Hrubis
2017-05-12T07:17:19Z

Hi!
> > > requested_us = tst_timespec_to_us(t->tv) * t->iterations;
> > >
> > > If slack_per_run is slack of all iterations, why is it multiplied
> > > again with number of iterations?
> >
> > That variable is poorly named. It should have been slack_per_call or
> > slack_per_iteration. It's slack per one syscall computed using the same
> > formula that is used in kernel...
>
> If it's per iteration, shouldn't this function be passed time per iteration?
> At the moment, it's time of all iterations:
> requested_us = tst_timespec_to_us(t->tv) * t->iterations;
> threshold = compute_threshold(requested_us, t->iterations);
>
> Should it be ... ?
> threshold = compute_threshold(tst_timespec_to_us(t->tv), t->iterations);

Good catch, I will fix that, retest and send v2.