From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] cve: Fix kernel symbol finding for meltdown case
Date: Thu, 22 Aug 2019 08:37:47 -0400 (EDT) [thread overview]
Message-ID: <1053175586.7790160.1566477467514.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <145293056.7577705.1566403293117.JavaMail.zimbra@redhat.com>
----- Original Message -----
>
>
> ----- Original Message -----
> > From: He Zhe <zhe.he@windriver.com>
> >
> > meltdown case fails as below.
> > safe_file_ops.c:219: BROK: Expected 3 conversions got 2 at meltdown.c:272
> >
> > find_kernel_symbol is defined to try twice with each of /proc/kallsyms and
> > /boot/System.map-%s. Currently if the symbol is not found in
> > /proc/kallsyms,
> > when kernel option CONFIG_KALLSYMS_ALL is disabled, it would stop the case
> > immediately due to SAFE_FILE_LINES_SCANF.
> >
> > This patch turns to use FILE_LINES_SCANF to give find_kernel_symbol second
> > chance.
>
> That explains it, thanks for the patch.
>
> We should also tweak TCONF condition in find_kernel_symbol - no need
> to re-post for that, I can add that.
Pushed, also with tweak for commit 7709d2ae92ea, so we try System.map,
even if kallsyms are completely disabled.
Regards,
Jan
prev parent reply other threads:[~2019-08-22 12:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 8:27 [LTP] [PATCH v2] cve: Fix kernel symbol finding for meltdown case zhe.he
2019-08-21 16:01 ` Jan Stancek
2019-08-22 12:37 ` Jan Stancek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1053175586.7790160.1566477467514.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox