From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] utimensat_tests.sh: returns EPERM on 4.4.27 and above
Date: Wed, 6 Sep 2017 07:54:20 -0400 (EDT) [thread overview]
Message-ID: <1059184676.9072017.1504698860809.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1504697434-22974-1-git-send-email-naresh.kamboju@linaro.org>
----- Original Message -----
> From: Naresh Kamboju <naresh.kamboju@linaro.org>
>
> Test utimensat failed on 4.4 kernel is due to expected error is
> EACCES but got EPERM.
>
> The below LTP patch setting up expected error as EACCES for 4.8.0 below
> kernel
> b9157aee: utimensat: re-apply: fix immutable file retcodes for 4.8.0 and
> newer
>
> Amending patch to check 4.4.27 instead of 4.8.0 according to below patch
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
> branch: v4.4.27
> commit id: b3b4283
> vfs: move permission checking into notify_change() for utimes(NULL)
>
> Bug reported on this case,
> LKFT: linux-stable-4.4: LTP utimensat01 failed-EXPECTED: EACCES but got EPERM
> https://bugs.linaro.org/show_bug.cgi?id=3142
>
> Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> ---
> testcases/kernel/syscalls/utimensat/utimensat_tests.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
> b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
> index 48154d6..a832433 100755
> --- a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
> +++ b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
> @@ -30,9 +30,9 @@ if tst_kvcmp -lt "2.6.22"; then
> tst_brkm TCONF "System kernel version is less than 2.6.22,cannot execute
> test"
> fi
>
> -# Starting with 4.8.0 operations on immutable files return EPERM instead of
> +# Starting with 4.4.27 operations on immutable files return EPERM instead of
> # EACCES.
> -if tst_kvcmp -lt "4.8.0"; then
> +if tst_kvcmp -lt "4.4.27"; then
Isn't this going to break the test for kernels 4.5 up to 4.7?
> imaccess=EACCES
> else
> imaccess=EPERM
> --
> 2.7.4
>
>
next prev parent reply other threads:[~2017-09-06 11:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 11:30 [LTP] [PATCH] utimensat_tests.sh: returns EPERM on 4.4.27 and above naresh.kamboju
2017-09-06 11:54 ` Jan Stancek [this message]
2017-09-06 15:29 ` Sumit Semwal
2017-09-25 14:46 ` Cyril Hrubis
2017-09-27 11:39 ` Cyril Hrubis
2017-09-27 13:55 ` Jan Stancek
2017-09-27 15:12 ` Cyril Hrubis
2017-09-27 22:38 ` Naresh Kamboju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1059184676.9072017.1504698860809.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox