* [LTP] typo in commit message
@ 2016-10-10 12:30 Cyril Hrubis
2016-10-10 12:39 ` Peter Maydell
2016-10-10 12:43 ` Jan Stancek
0 siblings, 2 replies; 4+ messages in thread
From: Cyril Hrubis @ 2016-10-10 12:30 UTC (permalink / raw)
To: ltp
Hi!
I've did a confusing typo in commit:
https://github.com/linux-test-project/ltp/commit/ebfb34503c7928368043182a2ac7750e805c4911
There is no such thing as ppc32le of course, it should have been
ppc64le. Is everyone OK with me force pushing with the simple change in
the commit message?
--
Cyril Hrubis
chrubis@suse.cz
^ permalink raw reply [flat|nested] 4+ messages in thread
* [LTP] typo in commit message
2016-10-10 12:30 [LTP] typo in commit message Cyril Hrubis
@ 2016-10-10 12:39 ` Peter Maydell
2016-10-10 12:43 ` Jan Stancek
1 sibling, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2016-10-10 12:39 UTC (permalink / raw)
To: ltp
On 10 October 2016 at 13:30, Cyril Hrubis <chrubis@suse.cz> wrote:
> Hi!
> I've did a confusing typo in commit:
> https://github.com/linux-test-project/ltp/commit/ebfb34503c7928368043182a2ac7750e805c4911
>
> There is no such thing as ppc32le of course, it should have been
> ppc64le. Is everyone OK with me force pushing with the simple change in
> the commit message?
I would strongly recommend against it. Once a commit has
gone public to master, doing a force-push that rewrites
history will break things for people.
thanks
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* [LTP] typo in commit message
2016-10-10 12:30 [LTP] typo in commit message Cyril Hrubis
2016-10-10 12:39 ` Peter Maydell
@ 2016-10-10 12:43 ` Jan Stancek
2016-10-10 12:46 ` Cyril Hrubis
1 sibling, 1 reply; 4+ messages in thread
From: Jan Stancek @ 2016-10-10 12:43 UTC (permalink / raw)
To: ltp
----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: ltp@lists.linux.it
> Sent: Monday, 10 October, 2016 2:30:34 PM
> Subject: [LTP] typo in commit message
>
> Hi!
> I've did a confusing typo in commit:
> https://github.com/linux-test-project/ltp/commit/ebfb34503c7928368043182a2ac7750e805c4911
>
> There is no such thing as ppc32le of course, it should have been
> ppc64le. Is everyone OK with me force pushing with the simple change in
> the commit message?
I would prefer to avoid force push, specially when we don't know
how many people already cloned it.
How about we do a revert and apply fixed patch instead?
Regards,
Jan
>
> --
> Cyril Hrubis
> chrubis@suse.cz
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-10 12:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-10 12:30 [LTP] typo in commit message Cyril Hrubis
2016-10-10 12:39 ` Peter Maydell
2016-10-10 12:43 ` Jan Stancek
2016-10-10 12:46 ` Cyril Hrubis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox