public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] clock_getres01: drop case which is passing NULL res parameter
Date: Tue, 13 Aug 2019 09:39:16 -0400 (EDT)	[thread overview]
Message-ID: <1087979527.6295007.1565703556506.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20190813131302.GA18888@rei.lan>



----- Original Message -----
> Hi!
> > > Shouldn't we keep the REALTIME clock here and pass the &res here
> > > instead?
> > 
> > Test already has that as 1st entry in tcase array:
> >    {"REALTIME", CLOCK_REALTIME, &res, 0, 0},
> 
> Missed that, sorry.

Me as well in v1 :-)

> 
> > > Can we please print which variant we are about to test from the test
> > > setup() as well?
> > 
> > Sure, I'll add that.
> 
> Consider the patch acked then.

Both pushed.

> 
> --
> Cyril Hrubis
> chrubis@suse.cz
> 

      reply	other threads:[~2019-08-13 13:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09 14:31 [LTP] [PATCH v2 1/2] clock_getres01: drop case which is passing NULL res parameter Jan Stancek
2019-08-09 14:31 ` [LTP] [PATCH v2 2/2] clock_getres01: add test variants Jan Stancek
2019-08-12  4:52   ` Li Wang
2019-08-13 12:13   ` Cyril Hrubis
2019-08-12  4:52 ` [LTP] [PATCH v2 1/2] clock_getres01: drop case which is passing NULL res parameter Li Wang
2019-08-13 12:12 ` Cyril Hrubis
2019-08-13 12:26   ` Jan Stancek
2019-08-13 13:13     ` Cyril Hrubis
2019-08-13 13:39       ` Jan Stancek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1087979527.6295007.1565703556506.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox