Re: [LTP] [PATCH V2] Fix short of nodemask array.

[Zhouping Liu <zliu@redhat.com>]

----- Original Message -----
> From: "Lans Zhang" <lans.zhang2008@gmail.com>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: "Zhouping Liu" <zliu@redhat.com>, "Wanlong Gao" <gaowanlong@cn.fujitsu.com>, ltp-list@lists.sourceforge.net
> Sent: Wednesday, April 17, 2013 4:35:36 PM
> Subject: Re: [LTP][PATCH V2] Fix short of nodemask array.
> 
> On 04/17/2013 03:37 PM, Jan Stancek wrote:
> >
> >
> >
> >
> > ----- Original Message -----
> >> From: "Lans Zhang"<lans.zhang2008@gmail.com>
> >> To: "Zhouping Liu"<zliu@redhat.com>, "Jan Stancek"<jstancek@redhat.com>
> >> Cc: "Wanlong Gao"<gaowanlong@cn.fujitsu.com>,
> >> ltp-list@lists.sourceforge.net
> >> Sent: Wednesday, 17 April, 2013 7:09:00 AM
> >> Subject: [LTP][PATCH V2] Fix short of nodemask array.
> >>
> >> Changes since V1:
> >> 1. Enhance patch header.
> >> 2. Use BITS_PER_LONG and set_node() to simplify the logic.
> >>
> >> In kernel, if user specified more nodes, e.g, 512 nodes, than the
> >> supported, e.g, 4 nodes, kernel will check if the non supported
> >> part, e.g, 508 nodes, is all zeroed in node bitmap. Currently, we
> >> are overrunning "nmask", whose length is shorter than MAXNODES,
> >> and where the unsupported bits should be cleared to pass the check.
> >>
> >> Signed-off-by: Lans Zhang<lans.zhang2008@gmail.com>
> >
> > Hi,
> >
> > 'v' should be probably dropped here, since it's not used and rest
> > of patch uses 2 parameters anyway:
> >
> >> +static inline void set_node(unsigned long *array, unsigned int node,
> >> +                            unsigned int v)
> >> +{
> >> +	array[node / BITS_PER_LONG] |= 1UL<<  (node % BITS_PER_LONG);
> >> +}
> >>
> >
> > Other than that, it looks good to me.
> 
> I will send a V3 if Zhouping Liu also gatekeep V2 except this minor
> change.

I'm also fine for the rest.
just one reminder: commit 0b3419364 modified lib/mem.c, which caused conflicts
with your patch, please prepare a new patch based on the latest tree, in order
to push it easily for maintainer.

-- 
Thanks,
Zhouping

------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list