From: Jan Stancek <jstancek@redhat.com>
To: Caspar Zhang <caspar@casparzhang.com>
Cc: LTP List <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH v2 1/2] numa_helper: move to libkerntest
Date: Mon, 6 Aug 2012 05:39:50 -0400 (EDT) [thread overview]
Message-ID: <1121805817.413044.1344245990666.JavaMail.root@redhat.com> (raw)
In-Reply-To: <2fbaeedd90ff07905a440eff5a3877bc7bf40f4c.1344234636.git.caspar@casparzhang.com>
Hi Caspar,
I found one small issue during my testing, but I suppose this can be fixed
in follow-up patch without need to resend whole series.
When I do "make clean" from LTP root, kernel/lib is not cleaned:
# ll testcases/kernel/lib/
total 36
-rw-r--r--. 1 root root 9704 Aug 6 05:27 libkerntest.a
-rw-rw-r--. 1 501 501 1051 Aug 6 03:21 Makefile
-rw-rw-r--. 1 501 501 6424 Aug 6 03:21 numa_helper.c
-rw-r--r--. 1 root root 9456 Aug 6 05:27 numa_helper.o
Regards,
Jan
----- Original Message -----
> From: "Caspar Zhang" <caspar@casparzhang.com>
> To: "LTP List" <ltp-list@lists.sourceforge.net>
> Sent: Monday, 6 August, 2012 8:30:50 AM
> Subject: [LTP] [PATCH v2 1/2] numa_helper: move to libkerntest
>
>
> libnuma_helper could be used by testcases both under syscalls/ and
> mem/,
> it's better to add a new common lib in their parent dir, so I created
> libkerntest under testcases/kernel/lib/, and put numa_helper to it.
> In
> the future, we can add more APIs to it.
>
> Signed-off-by: Caspar Zhang <caspar@casparzhang.com>
> ---
> testcases/kernel/include/lib.mk | 37 +++
> testcases/kernel/include/numa_helper.h | 37 +++
> testcases/kernel/lib/Makefile | 29 +++
> testcases/kernel/lib/numa_helper.c | 266
> ++++++++++++++++++++++
> testcases/kernel/syscalls/get_mempolicy/Makefile | 2 +-
> testcases/kernel/syscalls/mbind/Makefile | 2 +-
> testcases/kernel/syscalls/move_pages/Makefile | 2 +-
> testcases/kernel/syscalls/numa/Makefile | 22 --
> testcases/kernel/syscalls/numa/Makefile.inc | 27 ---
> testcases/kernel/syscalls/numa/lib/Makefile | 26 --
> testcases/kernel/syscalls/numa/lib/numa_helper.c | 266
> ----------------------
> testcases/kernel/syscalls/numa/lib/numa_helper.h | 37 ---
> 12 files changed, 372 insertions(+), 381 deletions(-)
> create mode 100644 testcases/kernel/include/lib.mk
> create mode 100644 testcases/kernel/include/numa_helper.h
> create mode 100644 testcases/kernel/lib/Makefile
> create mode 100644 testcases/kernel/lib/numa_helper.c
> delete mode 100644 testcases/kernel/syscalls/numa/Makefile
> delete mode 100644 testcases/kernel/syscalls/numa/Makefile.inc
> delete mode 100644 testcases/kernel/syscalls/numa/lib/Makefile
> delete mode 100644 testcases/kernel/syscalls/numa/lib/numa_helper.c
> delete mode 100644 testcases/kernel/syscalls/numa/lib/numa_helper.h
>
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond.
> Discussions
> will include endpoint security, mobile security and the latest in
> malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2012-08-06 9:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 6:30 [LTP] [PATCH v2 1/2] numa_helper: move to libkerntest Caspar Zhang
2012-08-06 6:30 ` [LTP] [PATCH v2 2/2] mm: use new numa_helper Caspar Zhang
2012-08-06 8:16 ` Jan Stancek
2012-08-06 8:33 ` Caspar Zhang
2012-08-06 8:38 ` [LTP] [PATCH v3 " Caspar Zhang
2012-08-06 9:32 ` Jan Stancek
2012-08-06 9:39 ` Jan Stancek [this message]
2012-08-06 11:58 ` [LTP] [PATCH v2 1/2] numa_helper: move to libkerntest Caspar Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1121805817.413044.1344245990666.JavaMail.root@redhat.com \
--to=jstancek@redhat.com \
--cc=caspar@casparzhang.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox