From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 6/6] syscalls/wait401: Rewrite to the new library
Date: Fri, 6 Apr 2018 04:54:22 -0400 (EDT) [thread overview]
Message-ID: <1134024977.11699650.1523004862083.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20180405145015.7633-7-chrubis@suse.cz>
----- Original Message -----
> + Get rid of the sleep(1) in the process
>
> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> + pid = SAFE_FORK();
> + if (!pid)
> + exit(0);
This doesn't seem to test that wait4() waits. The child can
end before call to wait4().
What if added call to tst_process_state_wait() to child,
so it waits on parent to sleep? If parent sleeps, then
it's likely waiting on child.
Regards,
Jan
next prev parent reply other threads:[~2018-04-06 8:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-05 14:50 [LTP] Get rid of few more useless sleep() calls Cyril Hrubis
2018-04-05 14:50 ` [LTP] [RFC PATCH 1/6] exit02: Rewrite to new library Cyril Hrubis
2018-04-06 8:47 ` Jan Stancek
2018-04-05 14:50 ` [LTP] [RFC PATCH 2/6] syscalls/pipe11: " Cyril Hrubis
2018-04-06 8:48 ` Jan Stancek
2018-04-05 14:50 ` [LTP] [RFC PATCH 3/6] syscalls/alarm05: Rewrite to the " Cyril Hrubis
2018-04-05 14:50 ` [LTP] [RFC PATCH 4/6] syscalls/alarm01: Remove Cyril Hrubis
2018-04-05 14:50 ` [LTP] [RFC PATCH 5/6] syscalls/waitpid01: Rewrite to the new library Cyril Hrubis
2018-04-05 14:50 ` [LTP] [RFC PATCH 6/6] syscalls/wait401: " Cyril Hrubis
2018-04-06 8:54 ` Jan Stancek [this message]
2018-04-09 9:44 ` Cyril Hrubis
2018-04-13 13:40 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1134024977.11699650.1523004862083.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox