From: Marius Kittler <mkittler@suse.de>
To: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1 1/2] Ensure prio is within valid range in `rt-migrate.c`
Date: Wed, 13 Sep 2023 11:27:51 +0200 [thread overview]
Message-ID: <11689901.tHia2Qjv5r@linux-9lzf> (raw)
In-Reply-To: <d57f969b-2b3c-4835-b9d0-b3b8f6b964e2@suse.com>
Am Mittwoch, 13. September 2023, 11:11:42 CEST schrieb Andrea Cervesato:
> Hi!
>
> I generally suggest to refactor test into new API if a structural
> change is needed.
That is why I refrained from a structural change and implemented the fix with
the minimum amount of change possible. This way the risk of introducing new
bugs should be very small and the low "hanging fruit" is grabbed.
> I would suggest to take a look at the code a bit closer and to guess how
> much effort we should put in order to rewrite it with new API.
I guess it would be doable and if that's wanted I can do that as the next step
as a separate commit. Not sure how long it'll take me, maybe a couple of hours
or a day (since I'm still new to ltp). (There is no ticket asking about such a
refactoring explicitly so I honestly don't know whether it is wanted or
whether we should invest our time better elsewhere.)
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-09-13 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 14:43 [LTP] [PATCH v1 0/2] Fix most severe problems with `rt-migrate.c` Marius Kittler
2023-09-12 14:43 ` [LTP] [PATCH v1 1/2] Ensure prio is within valid range in `rt-migrate.c` Marius Kittler
2023-09-13 9:11 ` Andrea Cervesato via ltp
2023-09-13 9:27 ` Marius Kittler [this message]
2023-11-13 9:31 ` Richard Palethorpe
2023-09-12 14:43 ` [LTP] [PATCH v1 2/2] Prevent segmentation fault when negative task count specified Marius Kittler
2023-09-13 8:54 ` Andrea Cervesato via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11689901.tHia2Qjv5r@linux-9lzf \
--to=mkittler@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox