Re: [LTP] [PATCH v4] syscalls/fallocate04: add new fallocate() test

Jan Stancek
2015-04-23T07:44:23Z

----- Original Message -----
> From: "Alexey Kodanev" <alexey.kodanev@oracle.com>
> To: ltp-list@lists.sourceforge.net
> Cc: "vasily isaenko" <vasily.isaenko@oracle.com>
> Sent: Tuesday, 21 April, 2015 3:05:07 PM
> Subject: [LTP] [PATCH v4] syscalls/fallocate04: add new fallocate() test
>
> This is a new functional test of fallocate() syscall with the focus on
> FALLOC_FL_ZERO_RANGE (since Linux 3.15) and FALLOC_FL_COLLAPSE_RANGE
> (since Linux 3.15) modes.
>
> Steps of test-cases:
> * allocate a file with specified size;
> * make a hole in the middle of the file with FALLOC_FL_PUNCH_HOLE;
> * fill the hole and adjacent space with FALLOC_FL_ZERO_RANGE;
> * remove a block from a file with FALLOC_FL_COLLAPSE_RANGE
>
> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
> ---
> v4: corrected Linux version for FALLOC_FL_ZERO_RANGE
> removed second Linux version check in test04()
> added 'EOPNOTSUPP' check for initial fallocate()
> v3: correctly indented second line in if blocks and tst_resm
> v2: replaced lseek, read, write, etc. with LTP safe macros
> moved FALLOC_FL_* macros to fallocate.h
> removed FALLOC_FL_KEEP_SIZE from fallocate03 (it is now in fallocate.h)
> made one more test-case (split setup())
>
> runtest/syscalls | 1 +
> testcases/kernel/syscalls/.gitignore | 1 +
> testcases/kernel/syscalls/fallocate/fallocate.h | 20 ++
> testcases/kernel/syscalls/fallocate/fallocate03.c | 1 -
> testcases/kernel/syscalls/fallocate/fallocate04.c | 273
> +++++++++++++++++++++
> 5 files changed, 295 insertions(+), 1 deletions(-)
> create mode 100644 testcases/kernel/syscalls/fallocate/fallocate04.c
>

v4 looks good, older kernels now end with TCONF. ACK

Regards,
Jan

------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF