public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/1] ltp-pan: Log start of test in kernel log
Date: Mon, 21 Aug 2017 08:49:29 -0400 (EDT)	[thread overview]
Message-ID: <1179658089.974834.1503319769581.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170821123024.pzddpd63gw3gbuhw@dell5510>



----- Original Message -----
> From: "Petr Vorel" <pvorel@suse.cz>
> To: "Cyril Hrubis" <chrubis@suse.cz>, jstancek@redhat.com
> Cc: ltp@lists.linux.it, "Li Wang" <liwang@redhat.com>
> Sent: Monday, 21 August, 2017 2:30:25 PM
> Subject: Re: [LTP] [PATCH 1/1] ltp-pan: Log start of test in kernel log
> 
> Hi Jan, Cyril,
> 
> thanks for your comments.
> 
> > > > I know ltp-pan is deprecated, but add kernel stamping can be useful for
> > > > debugging.
> 
> > > +1, it proved to be useful. It has also been mentioned couple weeks ago
> > > here:
> > >   https://lists.linux.it/pipermail/ltp/2017-June/004893.html
> 
> > > As I recall Cyril suggested an option to enable/disable this output,
> > > but I wouldn't mind if it was always-on.
> 
> > Maybe we should add an option to turn it off then, but apart from that
> > I'm for making this change.
> 
> Jan, would you like to push your change?
> If not, I'll add version with option to turn it off (default turn on).

I prefer you add the option to this patch, as it looks better.

Regards,
Jan

      reply	other threads:[~2017-08-21 12:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-21  9:06 [LTP] [PATCH 1/1] ltp-pan: Log start of test in kernel log Petr Vorel
2017-08-21 12:12 ` Jan Stancek
2017-08-21 12:17   ` Cyril Hrubis
2017-08-21 12:30     ` Petr Vorel
2017-08-21 12:49       ` Jan Stancek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1179658089.974834.1503319769581.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox