From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/mmap16: close open files in cleanup path
Date: Mon, 11 Jul 2016 08:19:30 -0400 (EDT) [thread overview]
Message-ID: <1194994844.3639216.1468239570693.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1467384925-24792-1-git-send-email-peter.maydell@linaro.org>
----- Original Message -----
> From: "Peter Maydell" <peter.maydell@linaro.org>
> To: ltp@lists.linux.it
> Cc: patches@linaro.org
> Sent: Friday, 1 July, 2016 4:55:25 PM
> Subject: [LTP] [PATCH] syscalls/mmap16: close open files in cleanup path
>
> If the mmap16 test fails while the do_test() function
> still has its filedescriptor open, the cleanup function's
> attempt to unmount will fail with EBUSY, resulting in a
> lot of noise in the test log, a leaked mounted filesystem
> and unnecessary test failures later in the run.
>
> Make the do_test() file descriptor global so we can
> close it in the cleanup function if necessary.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Hi,
pushed with small change, which treats uninitialized fd as -1, not 0.
Regards,
Jan
next prev parent reply other threads:[~2016-07-11 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 14:55 [LTP] [PATCH] syscalls/mmap16: close open files in cleanup path Peter Maydell
2016-07-11 12:19 ` Jan Stancek [this message]
2016-07-11 13:18 ` Peter Maydell
2016-07-11 14:04 ` Jan Stancek
2016-07-12 13:38 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194994844.3639216.1468239570693.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox