From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Stancek <jstancek@redhat.com>
Date: Tue, 17 May 2016 11:13:46 -0400 (EDT)
Subject: [LTP] [PATCH v2] creat05: don't assume number of opened fds
In-Reply-To: <20160517150155.GH12051@rei.lan>
References: <28627e5e1631723fccf734af32372e7fa4655ce7.1463496559.git.jstancek@redhat.com>
 <20160517150155.GH12051@rei.lan>
Message-ID: <1196430880.3549555.1463498026159.JavaMail.zimbra@redhat.com>
List-Id: <ltp.lists.linux.it>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ltp@lists.linux.it





----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp@lists.linux.it
> Sent: Tuesday, 17 May, 2016 5:01:55 PM
> Subject: Re: [PATCH v2] creat05: don't assume number of opened fds
> 
> Hi!
> > -	if (last_fd <= 0)
> > +	if (num_opened_fds == 0)
> >  		return;
> 
> We can leave out this if now since the for would be no-op now.

Right.

> 
> > -	for (fd = first_fd + 1; fd <= last_fd; fd++) {
> > -		if (close(fd))
> > -			tst_res(TWARN | TERRNO, "close(%i) failed", fd);
> > +	for (i = 0; i < num_opened_fds; i++) {
> > +		if (close(opened_fds[i])) {
> > +			tst_res(TWARN | TERRNO, "close(%i) failed",
> > +				opened_fds[i]);
> > +		}
> >  	}
> 
> We may also free the allocated array here.

Added free.

> 
> >  }
> 
> Otherwise it looks good, acked.

Thanks, pushed.

Regards,
Jan

> 
> --
> Cyril Hrubis
> chrubis@suse.cz
>