From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 3/3] syscalls/ioctl_ns0[156]: align stack and wait for child
Date: Thu, 13 Jun 2019 10:57:35 -0400 (EDT) [thread overview]
Message-ID: <1211798607.28016198.1560437855198.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20190613141714.GC29926@rei.lan>
----- Original Message -----
> Hi!
> > > We need free(child_stack) in the cleanup function.
> >
> > Can you elaborate?
>
> If I remember correctly at some point we decided to clean up after tests
> properly so that we don't upset various debugging tools, i.e. coverity,
> valgrind, etc. and I think that you were part of that discussion.
I recall I started with that position (free all), and I thought you
turned me around after this many years :-).
Do we have anything about this in style guide? I only found brief mention
in "don't call cleanup from setup" section, which isn't even possible with newlib.
...
You don't need to clean up the following:
* +malloc(3)+'ed memory.
* Read-only file descriptors in persistent paths (i.e. not
temporary directories).
>
> --
> Cyril Hrubis
> chrubis@suse.cz
>
next prev parent reply other threads:[~2019-06-13 14:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 7:23 [LTP] [PATCH v3 1/3] lib: add ltp_alloc_stack() Jan Stancek
2019-06-13 7:24 ` [LTP] [PATCH v3 2/3] lib: rename ltp_clone_malloc to ltp_clone_alloc Jan Stancek
2019-06-13 8:55 ` Li Wang
2019-06-13 13:57 ` Cyril Hrubis
2019-06-14 2:46 ` Li Wang
2019-06-14 15:24 ` Cyril Hrubis
2019-06-13 7:24 ` [LTP] [PATCH v3 3/3] syscalls/ioctl_ns0[156]: align stack and wait for child Jan Stancek
2019-06-13 8:25 ` Li Wang
2019-06-13 10:16 ` Jan Stancek
2019-06-13 11:26 ` Li Wang
2019-06-13 14:17 ` Cyril Hrubis
2019-06-13 14:57 ` Jan Stancek [this message]
2019-06-13 15:14 ` Cyril Hrubis
2019-06-16 7:34 ` Jan Stancek
2019-06-17 8:50 ` Cyril Hrubis
2019-06-17 14:38 ` Jan Stancek
2019-06-18 16:00 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1211798607.28016198.1560437855198.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox