Re: [LTP] [RFC] Patch getcpu01 testcase

[Subrata Modak <subrata@linux.vnet.ibm.com>]

On Fri, 2009-05-29 at 19:04 +0530, Suzuki Poulose wrote: 
> Subrata,
> 
> Good ! Then thats more suitable here :)
> 
> Refreshed the patch with TCONF and a better error message.

Thanks.

Regards--
Subrata

> 
> Thanks
> 
> Suzuki
> Subrata Modak wrote:
> > On Thu, 2009-05-28 at 22:32 +0530, Suzuki Poulose wrote:
> >> Hi,
> >>
> >> The getcpu01 always exits with a non-zero exit code (indicating a 
> >> Failure as per UNIX semantics) on non-NUMA machines.
> >>
> >> This is due to the following code :
> >>
> >>             tst_resm(TWARN,
> >>                     "/sys not mounted or not a numa system. Assuming
> >> one 
> >> node: %s",
> >>                          strerror(errno));
> >>
> >>
> >> Being a non-NUMA machine is not a failure, but an info. So it should
> >> not 
> >> cause the test to have a non zero exit status.
> > 
> > Correct,
> > 
> >> I have attached a patch which could do the same and provide a more 
> >> friendly o/p.
> >>
> >>
> >> Please apply.
> >>
> >> Thanks
> >> Suzuki
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >> plain text
> >> document
> >> attachment
> >> (fix-warning-getcpu01.diff)
> >>
> >>
> >> Index: ltp-20081031/testcases/kernel/syscalls/getcpu/getcpu01.c
> >> ===================================================================
> >> ---
> >> ltp-20081031.orig/testcases/kernel/syscalls/getcpu/getcpu01.c       2008-10-23 02:23:19.000000000 -0500
> >> +++
> >> ltp-20081031/testcases/kernel/syscalls/getcpu/getcpu01.c    2009-05-28
> >> 11:52:54.000000000 -0500
> >> @@ -47,6 +47,8 @@
> >>   * HISTORY
> >>   *     06/2008 written by Sharyathi Nagesh <sharyathi@in.ibm.com>
> >>   *
> >> + *     05/2009         Suzuki K P <suzuki@in.ibm.com>
> >> + *                     Friendly messages for non-NUMA machines.
> >>   * RESTRICTIONS
> >>   *     none
> >>   */
> >> @@ -234,8 +236,10 @@
> >>
> >>          directory_parent = opendir("/sys/devices/system/node");
> >>          if (!directory_parent)  {
> >> -                tst_resm(TWARN,
> >> -                   "/sys not mounted or not a numa system. Assuming
> >> one node: %s",
> >> +                tst_resm(TINFO,
> >> +                        "/sys not mounted or not a numa system.
> >> Assuming one node");
> >> +               tst_resm(TINFO,
> > 
> > Use TCONF instead of TINFO. That reflects that some system configuration
> > was missing, and, it will not return error value at all.
> > 
> > Regards--
> > Subrata
> > 
> >> +                       "Reason /sys/devices/system/node :%s",
> >>                          strerror(errno));
> >>                         return 0; //By Default assume it to belong to
> >> node Zero 
> >>          } else {
> >>
> > 
> 
> plain text document attachment (fix-warning-getcpu01.diff)
> Index: ltp-20081031/testcases/kernel/syscalls/getcpu/getcpu01.c
> ===================================================================
> --- ltp-20081031.orig/testcases/kernel/syscalls/getcpu/getcpu01.c	2008-10-23 02:23:19.000000000 -0500
> +++ ltp-20081031/testcases/kernel/syscalls/getcpu/getcpu01.c	2009-05-29 08:33:01.000000000 -0500
> @@ -47,6 +47,9 @@
>   * HISTORY
>   *	06/2008 written by Sharyathi Nagesh <sharyathi@in.ibm.com>
>   *
> + *	05/2009 	Suzuki K P <suzuki@in.ibm.com>
> + *			Use TCONF instead of TWARN for non-NUMA machines
> + *	
>   * RESTRICTIONS
>   *	none
>   */
> @@ -234,8 +237,10 @@
> 
>          directory_parent = opendir("/sys/devices/system/node");
>          if (!directory_parent)  {
> -                tst_resm(TWARN,
> -                   "/sys not mounted or not a numa system. Assuming one node: %s",
> +                tst_resm(TCONF,
> +                   "/sys not mounted or not a numa system. Assuming one node");
> +		tst_resm(TCONF,
> +			"Error opening: /sys/devices/system/node :%s",
>                          strerror(errno));
>                 	return 0; //By Default assume it to belong to node Zero 
>          } else {


------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT 
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, & 
iPhoneDevCamp as they present alongside digital heavyweights like Barbarian 
Group, R/GA, & Big Spaceship. http://p.sf.net/sfu/creativitycat-com 
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list