Re: [LTP] [RFC] Using checkpatch.pl

[Subrata Modak <subrata@linux.vnet.ibm.com>]

Send across a patch:
1) adding checkpatch.pl to LTP,
2) those instructions/future suggestions you have mentioned, update the
same in README.

Also remember to send patches against it in future when checkpatch.pl is
updated in the kernel tree itself.

Regards--
Subrata

On Sun, 2009-06-14 at 22:03 +0530, Vijay Kumar wrote: 
> Hi everyone,
> Michal Simek patched most of the LTP code base to use the Linux kernel
> coding style. But unfortunately new patches, that are flowing in, seem
> to add coding style violations. It is better to prevent new style
> violations than to fix them later on.
> 
> The kernel developers use a perl script called checkpatch.pl to
> identify style violations in patches. We could use the same script to
> check our patches, as well. The script uses files from the kernel to
> do kernel specific checks. This can be disabled by using the --no-tree
> option. So to check an LTP patch
> 
> $ checkpatch.pl --no-tree ltp-patch
> 
> If everybody is OK with it we can add the script to the LTP source
> tree, so that everyone checks their patches against the same
> script. And Subrata can easily check for style violations before
> merging the patch.
> 
> In the future, we could also customize the script to do userspace/LTP
> specific checks, like missing mode argument when open() is invoked
> with O_CREAT flag.
> 
> Please do send in your suggestions.
> 
> Regards,
> Vijay
> 
> ------------------------------------------------------------------------------
> Crystal Reports - New Free Runtime and 30 Day Trial
> Check out the new simplified licensing option that enables unlimited
> royalty-free distribution of the report engine for externally facing 
> server and web deployment.
> http://p.sf.net/sfu/businessobjects
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list


------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list