From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sfi-mx-1.v28.ch3.sourceforge.com ([172.29.28.121] helo=mx.sourceforge.net) by 335xhf1.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1MJkyV-0007GJ-Et for ltp-list@lists.sourceforge.net; Thu, 25 Jun 2009 09:10:31 +0000 Received: from e2.ny.us.ibm.com ([32.97.182.142]) by 29vjzd1.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69) id 1MJkyQ-00062S-3Q for ltp-list@lists.sourceforge.net; Thu, 25 Jun 2009 09:10:31 +0000 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e2.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n5P95afZ010957 for ; Thu, 25 Jun 2009 05:05:36 -0400 Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n5P9AOMk246634 for ; Thu, 25 Jun 2009 05:10:24 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n5P9AOZW025767 for ; Thu, 25 Jun 2009 05:10:24 -0400 From: Subrata Modak In-Reply-To: <200906232049.n5NKne0h007108@e5.ny.us.ibm.com> References: <200906232049.n5NKne0h007108@e5.ny.us.ibm.com> Date: Thu, 25 Jun 2009 14:39:33 +0530 Message-Id: <1245920973.5542.33.camel@subratamodak.linux.ibm.com> Mime-Version: 1.0 Subject: Re: [LTP] [PATCH] Run the eventfd test in a temporary directory, because it creates some files Reply-To: subrata@linux.vnet.ibm.com List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Jiri Palecek , "Vijay Kumar B." Cc: ltp-list@lists.sourceforge.net, Davide Libenzi On Mon, 2008-12-29 at 14:48 +0100, Jiri Palecek wrote: > Hello, > > the eventfd test creates some files in the current directory. I think it should be creating the files in a temporary directory instead, as is already the standard with other LTP tests, because the current might be nonwriteable and the user might not want the files left there. > > Regards > Jiri Palecek > > Signed-off-by: Jiri Palecek Thanks. Recently i have seen some patches on LKML from Davide on the change for eventfd() interface. Could you please verify how they will affect our tests, and, make changes if necessary ? http://lkml.org/lkml/2009/6/24/590, Regards-- Subrata > --- > testcases/kernel/syscalls/eventfd/eventfd01.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/testcases/kernel/syscalls/eventfd/eventfd01.c b/testcases/kernel/syscalls/eventfd/eventfd01.c > index ee09752..0eed8d1 100644 > --- a/testcases/kernel/syscalls/eventfd/eventfd01.c > +++ b/testcases/kernel/syscalls/eventfd/eventfd01.c > @@ -759,6 +759,8 @@ static void setup(void) > if (tst_kvercmp(2, 6, 22) < 0) > tst_brkm(TCONF, cleanup, "2.6.22 or greater kernel required"); > > + /* Create a temporary directory & chdir there */ > + tst_tmpdir(); > /* Pause if that option was specified > * TEST_PAUSE contains the code to fork the test with the -c option. > */ > @@ -776,6 +778,7 @@ static void cleanup(void) > */ > TEST_CLEANUP; > > + tst_rmdir(); > /* exit with return code appropriate for results */ > tst_exit(); > /*NOTREACHED*/} ------------------------------------------------------------------------------ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list