From: Subrata Modak <subrata@linux.vnet.ibm.com>
To: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Cc: "M. Mohan Kumar" <mohan@in.ibm.com>,
sachinp@in.ibm.com, ltp-list@lists.sf.net
Subject: Re: [LTP] [PATCH] Fix pidns14 test case
Date: Mon, 06 Jul 2009 21:20:23 +0530 [thread overview]
Message-ID: <1246895423.4887.43.camel@subratamodak.linux.ibm.com> (raw)
In-Reply-To: <20090701195605.GA23307@us.ibm.com>
Suka,
So, what should i do finally ?? Drop this ?
Regards--
Subrata
On Wed, 2009-07-01 at 12:56 -0700, Sukadev Bhattiprolu wrote:
> Serge E. Hallyn [serue@us.ibm.com] wrote:
> | Quoting M. Mohan Kumar (mohan@in.ibm.com):
> | > [PATCH] pidns14
> | >
> | > Container-init may be immune to unhandled fatal signals (like SIGUSR1)
> | > even if they are from ancestor namespace. SIGKILL/SIGSTOP are the only
> | > reliable signals to a container-init from ancestor namespace. Make sure
> | > that container-init will not respond to signals other than
> | > SIGKILL/SIGSTOP
> |
> | Hmm? This may or may not be right... but you start out by saying 'may be
> | immune to', then provide a patch making the testcase TFAIL if is not immune
> | to. So at the very least anyone on a slightly older kernel will get TFAILs.
> |
> | I don't think that immunity to SIGUSR1 from ancestor pidns is something we
> | want to guarantee, it's just what is happening. The proper thing is to
> | not depend on either getting or not getting SIGUSR1, in my opinion. Suka?
>
> Yes we did confirm that there is a test for SIGKILL from parent ns.
> We discussed in the bug report on whether to drop or modify the test,
> but leaned towards modifying the test bc if SIGUSR1 does kill a container
> init, then something has changed in the sig_ignored() checks in the kernel.
>
> Hmm, not a very strong reason to keep the test. Lets just drop the test :-)
>
> Sukadev
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2009-07-06 15:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 16:59 [LTP] [PATCH] Fix pidns14 test case M. Mohan Kumar
2009-07-01 18:20 ` Serge E. Hallyn
2009-07-01 19:56 ` Sukadev Bhattiprolu
2009-07-06 15:50 ` Subrata Modak [this message]
2009-07-07 16:48 ` Sukadev Bhattiprolu
2009-07-08 18:13 ` Subrata Modak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1246895423.4887.43.camel@subratamodak.linux.ibm.com \
--to=subrata@linux.vnet.ibm.com \
--cc=ltp-list@lists.sf.net \
--cc=mohan@in.ibm.com \
--cc=sachinp@in.ibm.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox