Re: [LTP] [PATCH 4/4] netns: Change interpretters from sh to bash

[Subrata Modak <subrata@linux.vnet.ibm.com>]

On Thu, 2009-07-02 at 13:32 -0700, Matt Helsley wrote: 
> On Thu, Jul 02, 2009 at 02:35:46PM -0400, Mike Frysinger wrote:
> > On Thursday 02 July 2009 05:05:32 Matt Helsley wrote:
> > > As best I can tell these tests do not use true sh syntax -- they use bash
> > > syntax. Rather than bother hunting down all the bash-isms just convert
> > > them to use bash as their interpretter.
> > 
> > the changelog doesnt seem to jive with the commit.  if you were merely 
> > changing the shebang, why did you also fix the bashisms like s/==/-eq/ ?
> 
> Good point -- it does make the == -> -eq and the || -> -o conversions
> pointless.
> 
> > 
> > at any rate, someone (i dont recall who) posted fixes to these files recently 
> > to de-bashify them.  there was some feedback though, so perhaps you should 
> > address those minor issues and submit an updated patch.
> 
> OK, I'll look for that patch and consider it as a replacement for 3 and 4 of
> this series.

Will wait for this from you.

Regards--
Subrata

> 
> > 
> > in general, converting sh to bash is a bad idea as it can cause issues for us 
> > embedded peeps.
> > -mike
> 
> I suppose that's because of the memory bash consumes. Is there anything else
> it does which is bad for embedded?
> 
> Cheers,
> 	-Matt Helsley


------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list