Re: [LTP] [PATCH] Fix failure of the utimes01 test

[Subrata Modak <subrata@linux.vnet.ibm.com>]

On Thu, 2009-07-09 at 15:35 +0800, Wang Yong wrote: 
> Whenever system called utimes, the error message returned was EINVAL,
> because the member variable of struct timeval was not initialized,
> so initialize it.
> 
> Signed-off-by:　WangYong　<wangyong2009@cn.fujitsu.com>
> 
> diff -Nurp ltp-full-20090630/testcases/kernel/syscalls/utimes/utimes01.c
> ltp-full-20090630.new/testcases/kernel/syscalls/utimes/utimes01.c
> --- ltp.orig/testcases/kernel/syscalls/utimes/utimes01.c 2009-07-01
> 17:20:12.000000000 +0800
> +++ ltp/testcases/kernel/syscalls/utimes/utimes01.c  2009-07-08
> 17:20:38.000000000 +0800
> @@ -248,6 +248,7 @@ static int do_test(struct test_case *tc)
>           /*
>            * Execute system call
>            */
> +        memset(tv, 0, 2 * sizeof(struct timeval));

Initializing this is good. But i do not find any visible difference in
running this test pre and post patching either on 2.6.29 or 2.6.18
kernels. The following output is generated each time:

# ./testcases/bin/utimes01 
utimes01    0  INFO  :  (case00) START
open failed.
utimes01    0  INFO  :  (case00) END => NG
utimes01    0  INFO  :  (case01) START
open failed.
utimes01    0  INFO  :  (case01) END => NG
utimes01    0  INFO  :  (case02) START
open failed.
utimes01    0  INFO  :  (case02) END => NG
utimes01    0  INFO  :  (case03) START
open failed.
utimes01    0  INFO  :  (case03) END => NG
utimes01    0  INFO  :  (case04) START
open failed.
utimes01    0  INFO  :  (case04) END => NG
utimes01    1  FAIL  :  utimes01 failed - errno = 2 : No such file or
directory
utimes01    0  INFO  :  NG

# echo $?
1

Regards--
Subrata

> tv[0].tv_sec = tc->a_sec;
>           tv[1].tv_sec = tc->m_sec;
>           TEST(len = strlen(fpath));
> 
> 
> 
> ------------------------------------------------------------------------------
> Enter the BlackBerry Developer Challenge  
> This is your chance to win up to $100,000 in prizes! For a limited time, 
> vendors submitting new applications to BlackBerry App World(TM) will have
> the opportunity to enter the BlackBerry Developer Challenge. See full prize  
> details at: http://p.sf.net/sfu/Challenge
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list


------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list