Re: [LTP] FW: FW: My first Patch

[Subrata Modak <subrata@linux.vnet.ibm.com>]

On Fri, 2009-07-10 at 09:32 +0530, Praveen wrote: 
> Hi,
> 
> Apologies for the inconvenience
> 
> Please find the patch attached with this email (Now "diff -uprN" is used to
> generate the patch)
> 

Thanks. Good start. Just few points:

     1. Create patches from LTPROOT directory. Itś very difficult to
        find the subdirectory during patch application, if you had
        created from deep inside the LTP tree, 
     2. Always include a DCO signoff, like: Signed-off-by: Praveen
        <praveen@primesoftsolutionsinc.com>,

Hope to see more patches from you in future.

Regards--
Subrata

> 
> Thanks, 
> Praveen Kumar k
> 
> 
> -----Original Message-----
> From: Subrata Modak [mailto:subrata@linux.vnet.ibm.com] 
> Sent: Tuesday, July 07, 2009 9:03 PM
> To: Praveen
> Cc: ltp-list@lists.sourceforge.net; 'Naresh'; 'Nathan Straz'
> Subject: Re: FW: My first Patch
> 
> Praveen. Please use this:
> 
> diff -uprN
> 
> to generate your patches.
> 
> Regards--
> Subrata
> 
> On Tue, 2009-07-07 at 16:45 +0530, Praveen wrote: 
> > Hi Subrata,
> > 
> >  
> > 
> > Please find my first 'file' command test patch attached with this
> > email.
> > 
> >  
> > 
> > I have added detailed description of what individual test case does at
> > the top 
> > 
> > of the test. Please feel free to review and provide me with your
> > comments.
> > 
> >  
> > 
> > The 'file' command test case in LTP test suite exists in path:
> > 
> >  "ltp-xxx/testcases/commands/ade/file/"
> > 
> >  
> > 
> > Thanks,
> > 
> > Praveen Kumar k
> > 
> >  
> > 
> > 
> 
> 


------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list