public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] [PATCH] Cross-compile configure bug
@ 2009-08-19 23:11 Garrett Cooper
  2009-08-23  7:28 ` Subrata Modak
  2009-08-25  1:15 ` [LTP] [Openhpi-devel] " Ric White
  0 siblings, 2 replies; 9+ messages in thread
From: Garrett Cooper @ 2009-08-19 23:11 UTC (permalink / raw)
  To: openhpi-devel; +Cc: LTP list

Hi,
    Found this bug while trying to cross-compile with the
openhpi-test-suite in LTP, and made the ERROR into WARN. Please fix
this item as per the attached patch.
Thanks,
-Garrett

PS Please CC my address in all correspondence w.r.t. this email thread.

Summary:

1. int != 4 shouldn't be checked for while cross-compiling.
2. Warn instead of erroring out, because we have a _lot_ of 64-bit
platforms that we test on which will be negatively impacted by this
check.

Signed-off-by: Garrett Cooper <yanegomi@gmail.com>

--- /nfs.mac/ltp-upgrade/contrib/ltp/src/testcases/open_hpi_testsuite//configure.ac.orig	2009-08-19
16:04:08.000000000 -0700
+++ /nfs.mac/ltp-upgrade/contrib/ltp/src/testcases/open_hpi_testsuite//configure.ac	2009-08-19
16:10:47.000000000 -0700
@@ -44,14 +44,13 @@
 AC_PROG_LN_S
 AC_PROG_MAKE_SET

-dnl die on int != 32bits.  This is too instrumental to our code right now.
+dnl Warn when int != 32bits.  This is too instrumental to our code right now.
 dnl AC_MSG_CHECKING(int is 4 bytes)
 OH_SET_SIZES
-if test "x$OH_SIZEOF_INT" != "x4"; then
-    AC_MSG_ERROR([
+if test x$cross_compiling != xyes && test "x$OH_SIZEOF_INT" != "x4"; then
+    AC_MSG_WARN([
 *** int is not 4 bytes, it is $OH_SIZEOF_INT bytes on this platform
-*** undefined behavior will result
-*** please contact the openhpi development team to fix this
+*** undefined behavior may result from this.
 ])
 fi

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2009-08-27  0:51 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-19 23:11 [LTP] [PATCH] Cross-compile configure bug Garrett Cooper
2009-08-23  7:28 ` Subrata Modak
2009-08-25  1:15 ` [LTP] [Openhpi-devel] " Ric White
2009-08-25  5:42   ` anton.pak
2009-08-25 15:12     ` Shuah Khan
2009-08-25 15:19       ` Anton Pak
2009-08-25 17:42         ` Shuah Khan
2009-08-26  0:16           ` Garrett Cooper
2009-08-27  0:51             ` Ric White

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox