From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sfi-mx-3.v28.ch3.sourceforge.com ([172.29.28.123] helo=mx.sourceforge.net) by h25xhf1.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1MrVXy-00069l-O8 for ltp-list@lists.sourceforge.net; Sat, 26 Sep 2009 11:34:38 +0000 Received: from fg-out-1718.google.com ([72.14.220.154]) by 3b2kzd1.ch3.sourceforge.com with esmtp (Exim 4.69) id 1MrVXq-0004e3-9l for ltp-list@lists.sourceforge.net; Sat, 26 Sep 2009 11:34:38 +0000 Received: by fg-out-1718.google.com with SMTP id e21so396723fga.10 for ; Sat, 26 Sep 2009 04:34:24 -0700 (PDT) From: Andrew Vagin Date: Sat, 26 Sep 2009 15:34:17 +0400 Message-Id: <1253964859-23928-1-git-send-email-avagin@gmail.com> Subject: [LTP] [PATCH 1/3] fsstress: fix memory leaks List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: subrata@linux.vnet.ibm.com Cc: ltp-list@lists.sourceforge.net ==11424== 156 bytes in 1 blocks are definitely lost in loss record 2 of 2 ==11424== at 0x4A0763E: malloc (vg_replace_malloc.c:207) ==11424== by 0x402E4C: make_freq_table (fsstress.c:986) ==11424== by 0x401C26: main (fsstress.c:410) make_freq_table is executed on each iterations, but freq_table is not changed during test, so this patch moves it from the loop --- testcases/kernel/fs/fsstress/fsstress.c | 30 ++++++++++++++++-------------- 1 files changed, 16 insertions(+), 14 deletions(-) diff --git a/testcases/kernel/fs/fsstress/fsstress.c b/testcases/kernel/fs/fsstress/fsstress.c index 1f11f6e..3df0ce5 100644 --- a/testcases/kernel/fs/fsstress/fsstress.c +++ b/testcases/kernel/fs/fsstress/fsstress.c @@ -375,21 +375,24 @@ int main(int argc, char **argv) break; } } - while ( (loopcntr <= loops) || (loops == 0) ) - { - if (no_xfs && errtag) { - fprintf(stderr, "error injection only works on XFS\n"); - exit(1); - } - if (no_xfs) { - int i; - for (i = 0; ops+i < ops_end; ++i) { - if (ops[i].isxfs) - ops[i].freq = 0; - } + if (no_xfs && errtag) { + fprintf(stderr, "error injection only works on XFS\n"); + exit(1); + } + + if (no_xfs) { + int i; + for (i = 0; ops+i < ops_end; ++i) { + if (ops[i].isxfs) + ops[i].freq = 0; } - + } + + make_freq_table(); + + while ( (loopcntr <= loops) || (loops == 0) ) + { if (!dirname) { /* no directory specified */ if (!nousage) usage(); @@ -407,7 +410,6 @@ int main(int argc, char **argv) maxfsize = (off64_t)MAXFSIZE32; else maxfsize = (off64_t)MAXFSIZE; - make_freq_table(); dcache_init(); setlinebuf(stdout); if (!seed) { -- 1.6.2.5 ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list