Re: [LTP] [PATCH][openfile] file descriptors not cleaned up

[Subrata Modak <subrata@linux.vnet.ibm.com>]

On Mon, 2009-10-05 at 14:33 -0700, Henry Yei wrote: 
> On Wednesday 04, October 2009 04:06:46 Jiri Palecek wrote:
> 
> Hello,
> 
> On Wednesday 30 September 2009 04:06:46 Henry Yei wrote:
> > This patch for openfile contains the following changes:
> > - test output to use tst_resm functions
> > - sets ups and cleans up tmp dir properly
> > - closes all opened file descriptors before thread exit(fixes nfs issues on removing tmp dir)
> > 
> > Signed-off-by: Henry Yei <hyei@mvista.com>
> > 
> > 
> > This test opens multiple file descriptors to the same file. Perhaps the author meant to open file handles for separate files?
> 
> This is suspicious, for me too. But maybe there is some logic behind opening the same file many times.
> 
> I just have a small remark about your patch: Shouldn't you call close_files() here, too? (With a partially full fd_list array handled, of course)
> 
> +void * threads(void* thread_id_) {
> +	int thread_id = (uintptr_t) thread_id_;
> +	char errmsg[80];
> +	FILE *fd_list[MAXFILES];
> +	int i;
> +
> +	/* Open files */
> +	for (i = 0; i < numfiles; i++) {
> +		if (debug)
> +			printf("Thread  %d : Opening file number %d \n", thread_id, i);
> +		if ((fd_list[i] = fopen(filename, "rw")) == NULL) {
> +			sprintf(errmsg, "FAIL - Couldn't open file #%d", i);
> +			perror(errmsg);
> 
> 
> 
> Jiri, 
> 
> Thanks for reviewing the patch. Yes, that was an omission on my part. I have attached an updated patch. Let me know if there are any more comments.
> 

Henry,

This patch is ineffective on the present Makefile(s). Please rebase them
over latest CVS and resend:

patching file testcases/kernel/fs/openfile/Makefile
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file
testcases/kernel/fs/openfile/Makefile.rej
patching file testcases/kernel/fs/openfile/openfile.c

Regards--
Subrata

> 
> 
> Henry Yei
> 
> 
> 
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay 
> ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
> http://p.sf.net/sfu/devconf
> _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list


------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list