Re: [LTP] [PATCH] Other compiler warning fixes

[Subrata Modak <subrata@linux.vnet.ibm.com>]

Thanks. Just a small correction below:

On Wed, 2009-10-21 at 21:37 +0200, Jiri Palecek wrote: 
> Hello,
> 
> this is another chunk of compiler warning fixes in LTP tests, related to printf format strings. They have multiple causes:
> 
>  - most of them are caused by %d used for the TEST_RETURN variable (as in a previous patch)
> 
>  - off_t are cast to (int64_t) and PRId64 output specifier is used for them
> 
>  - other types are cast to (intmax_t) or (uintmax_t) and use the %jd or %ju (C99) output specifier. I've used this solution because it's generally correct, easy to use solution that is portable and (IMHO) more readable than using PRId64/PRIu64 and a cast (which you generally can't avoid). This way, there's only a cast.
> 
>  - in ioperm test, address should be declared as unsigned long (according to ioperm(2))
> 
>  - other little fixes (foo vs. *foo, %S vs. %s, %0 vs. %o)
> 
> Regards
>     Jiri Palecek
> 
> diff --git a/testcases/kernel/syscalls/socketcall/socketcall03.c b/testcases/kernel/syscalls/socketcall/socketcall03.c
> index 9cc2de4..de63784 100644
> --- a/testcases/kernel/syscalls/socketcall/socketcall03.c
> +++ b/testcases/kernel/syscalls/socketcall/socketcall03.c
> @@ -127,12 +127,12 @@ int main(int ac, char **av)
>  		/* check return code */
> 
>  		if (TEST_RETURN == -1) {
> -			tst_resm(TFAIL, "socketcall() Failed "
> -				 " with return=%d,errno=%d: %s",
> -				 TEST_RETURN, TEST_ERRNO, strerror(TEST_ERRNO));
> +			tst_resm(TFAIL|TTERNO, "socketcall() Failed "

+ tst_resm(TFAIL|TERRNO, "socketcall() Failed "

Regards--
Subrata



------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list