[LTP] [PATCH v2 0/3] autotools: Remove old checks

[LTP] [PATCH v2 0/3] autotools: Remove old checks

[Petr Vorel]

Changes v1->v2:
* Fix compilation error missing endif

Link to v1:
https://patchwork.ozlabs.org/project/ltp/list/?series=468404&state=*

Petr Vorel (3):
  Remove m4/ltp-signalfd.m4
  m4: lapi: Drop check for old libcap-devel
  m4: fcntl31: Remove check for struct f_owner_ex

 configure.ac                              |  2 --
 include/lapi/capability.h                 |  8 --------
 m4/ltp-cap.m4                             | 17 +----------------
 m4/ltp-fcntl.m4                           | 21 ---------------------
 m4/ltp-signalfd.m4                        | 17 -----------------
 testcases/kernel/syscalls/fcntl/fcntl31.c |  8 --------
 6 files changed, 1 insertion(+), 72 deletions(-)
 delete mode 100644 m4/ltp-fcntl.m4
 delete mode 100644 m4/ltp-signalfd.m4

-- 
2.50.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH v2 1/3] Remove m4/ltp-signalfd.m4

[Petr Vorel]

HAVE_STRUCT_SIGNALFD_SIGINFO_SSI_SIGNO autotols check was used only in
testcases/kernel/syscalls/signalfd/signalfd01.c before it got rewritten
to the new API in a569202b6e.

Fixes: a569202b6e ("signalfd01: Refactor old case with new API")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 configure.ac       |  1 -
 m4/ltp-signalfd.m4 | 17 -----------------
 2 files changed, 18 deletions(-)
 delete mode 100644 m4/ltp-signalfd.m4

diff --git a/configure.ac b/configure.ac
index db41175bf2..5362aaf1bc 100644
--- a/configure.ac
+++ b/configure.ac
@@ -414,7 +414,6 @@ fi
 AC_DEFINE_UNQUOTED(NUMA_ERROR_MSG, ["$numa_error_msg"], [Error message when no NUMA support])
 
 
-LTP_CHECK_SYSCALL_SIGNALFD
 LTP_CHECK_SYSCALL_UTIMENSAT
 LTP_CHECK_TASKSTATS
 test "x$with_tirpc" = xyes && LTP_CHECK_TIRPC
diff --git a/m4/ltp-signalfd.m4 b/m4/ltp-signalfd.m4
deleted file mode 100644
index 5aac395bd7..0000000000
--- a/m4/ltp-signalfd.m4
+++ /dev/null
@@ -1,17 +0,0 @@
-dnl SPDX-License-Identifier: GPL-2.0-or-later
-dnl Copyright (c) Red Hat Inc., 2008
-dnl Copyright (c) 2019 Fujitsu Ltd.
-dnl Author: Masatake YAMATO <yamato@redhat.com>
-
-AC_DEFUN([LTP_CHECK_SYSCALL_SIGNALFD],[
-
-AC_CHECK_FUNCS(signalfd,,)
-AC_CHECK_HEADERS([sys/signalfd.h],,)
-AC_CHECK_HEADERS([linux/signalfd.h],,)
-AC_CHECK_MEMBERS([struct signalfd_siginfo.ssi_signo],,,[
-#if defined HAVE_SYS_SIGNALFD_H
-#include <sys/signalfd.h>
-#elif defined HAVE_LINUX_SIGNALFD_H
-#include <linux/signalfd.h>
-#endif])
-])
-- 
2.50.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2 1/3] Remove m4/ltp-signalfd.m4

[Avinesh Kumar]

On Friday, August 8, 2025 1:01:00 PM CEST Petr Vorel wrote:
> HAVE_STRUCT_SIGNALFD_SIGINFO_SSI_SIGNO autotols check was used only in
s/autotols/autotools

Reviewed-by: Avinesh Kumar <akumar@suse.de>
for all patches in this series.

Thanks,
Avinesh

> testcases/kernel/syscalls/signalfd/signalfd01.c before it got rewritten
> to the new API in a569202b6e.
> 
> Fixes: a569202b6e ("signalfd01: Refactor old case with new API")
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  configure.ac       |  1 -
>  m4/ltp-signalfd.m4 | 17 -----------------
>  2 files changed, 18 deletions(-)
>  delete mode 100644 m4/ltp-signalfd.m4
> 
> diff --git a/configure.ac b/configure.ac
> index db41175bf2..5362aaf1bc 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -414,7 +414,6 @@ fi
>  AC_DEFINE_UNQUOTED(NUMA_ERROR_MSG, ["$numa_error_msg"], [Error message when no NUMA support])
>  
>  
> -LTP_CHECK_SYSCALL_SIGNALFD
>  LTP_CHECK_SYSCALL_UTIMENSAT
>  LTP_CHECK_TASKSTATS
>  test "x$with_tirpc" = xyes && LTP_CHECK_TIRPC
> diff --git a/m4/ltp-signalfd.m4 b/m4/ltp-signalfd.m4
> deleted file mode 100644
> index 5aac395bd7..0000000000
> --- a/m4/ltp-signalfd.m4
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -dnl SPDX-License-Identifier: GPL-2.0-or-later
> -dnl Copyright (c) Red Hat Inc., 2008
> -dnl Copyright (c) 2019 Fujitsu Ltd.
> -dnl Author: Masatake YAMATO <yamato@redhat.com>
> -
> -AC_DEFUN([LTP_CHECK_SYSCALL_SIGNALFD],[
> -
> -AC_CHECK_FUNCS(signalfd,,)
> -AC_CHECK_HEADERS([sys/signalfd.h],,)
> -AC_CHECK_HEADERS([linux/signalfd.h],,)
> -AC_CHECK_MEMBERS([struct signalfd_siginfo.ssi_signo],,,[
> -#if defined HAVE_SYS_SIGNALFD_H
> -#include <sys/signalfd.h>
> -#elif defined HAVE_LINUX_SIGNALFD_H
> -#include <linux/signalfd.h>
> -#endif])
> -])
> 





-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH v2 2/3] m4: lapi: Drop check for old libcap-devel

[Petr Vorel]

Upstream fix [1] was released in libcap-2.17 released in 2009.
Even old SLES12 we still use for testing has newer libcap,
we can remove the check.

[1] https://git.kernel.org/pub/scm/libs/libcap/libcap.git/commit/?id=012bca3265ed0d84b57531919a390645052d810e

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Changes v1->v2:
* Fix compilation error missing endif
 include/lapi/capability.h |  8 --------

 m4/ltp-cap.m4             | 17 +----------------
 2 files changed, 1 insertion(+), 24 deletions(-)

diff --git a/include/lapi/capability.h b/include/lapi/capability.h
index 14d2d3c12c..d3cc121fc1 100644
--- a/include/lapi/capability.h
+++ b/include/lapi/capability.h
@@ -10,14 +10,6 @@
 
 #ifdef HAVE_SYS_CAPABILITY_H
 # include <sys/capability.h>
-/**
- * Some old libcap-devel(1.96~2.16) define _LINUX_TYPES_H in
- * sys/capability.h that makes ltp-lib cann't include linux/types.h
- * essentially. Here undefine it if include such old header-file.
- */
-# ifndef HAVE_NEWER_LIBCAP
-#  undef _LINUX_TYPES_H
-# endif
 #endif
 
 #ifndef CAP_NET_BIND_SERVICE
diff --git a/m4/ltp-cap.m4 b/m4/ltp-cap.m4
index 4981e843da..6b26e7d15c 100644
--- a/m4/ltp-cap.m4
+++ b/m4/ltp-cap.m4
@@ -1,6 +1,6 @@
 dnl SPDX-License-Identifier: GPL-2.0-or-later
 dnl Copyright (c) Cisco Systems Inc., 2009
-dnl Copyright (c) Linux Test Project, 2019
+dnl Copyright (c) Linux Test Project, 2019-2025
 dnl Author: Ngie Cooper <yaneurabeya@gmail.com>
 
 AC_DEFUN([LTP_CHECK_CAPABILITY_SUPPORT],[
@@ -14,19 +14,4 @@ if test "x$cap_libs" != x; then
 	AC_DEFINE(HAVE_LIBCAP)
 fi
 AC_SUBST(CAP_LIBS,$cap_libs)
-
-AH_TEMPLATE(HAVE_NEWER_LIBCAP,
-[Define to 1 if you have newer libcap-2 installed.])
-AC_COMPILE_IFELSE([AC_LANG_SOURCE([
-#include <sys/capability.h>
-#include <linux/types.h>
-int main(void) {
-	__u16 a;
-	__u32 b;
-	return 0;
-}])],[has_newer_libcap="yes"])
-
-if test "x$has_newer_libcap" = xyes; then
-	AC_DEFINE(HAVE_NEWER_LIBCAP)
-fi
 ])
-- 
2.50.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH v2 3/3] m4: fcntl31: Remove check for struct f_owner_ex

[Petr Vorel]

struct f_owner_ex support was added to glibc 2.11 released in 2009.
Other libc of course contain it as well (musl, uclibc-ng, bionic) and we
can safely assume it's widely supported.

The check m4/ltp-fcntl.m4 was unnecessarily complicated. Adding struct
into AC_CHECK_TYPES in configure.ac would be much faster than compile
with AC_COMPILE_IFELSE.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 configure.ac                              |  1 -
 m4/ltp-fcntl.m4                           | 21 ---------------------
 testcases/kernel/syscalls/fcntl/fcntl31.c |  8 --------
 3 files changed, 30 deletions(-)
 delete mode 100644 m4/ltp-fcntl.m4

diff --git a/configure.ac b/configure.ac
index 5362aaf1bc..62ae27d494 100644
--- a/configure.ac
+++ b/configure.ac
@@ -397,7 +397,6 @@ LTP_CHECK_LIBMNL
 LTP_CHECK_SELINUX
 LTP_CHECK_SYNC_ADD_AND_FETCH
 LTP_CHECK_SYSCALL_EVENTFD
-LTP_CHECK_SYSCALL_FCNTL
 LTP_CHECK_FSVERITY
 
 AX_CHECK_COMPILE_FLAG([-no-pie], [LTP_CFLAGS_NOPIE=1])
diff --git a/m4/ltp-fcntl.m4 b/m4/ltp-fcntl.m4
deleted file mode 100644
index 90ab5fd0fc..0000000000
--- a/m4/ltp-fcntl.m4
+++ /dev/null
@@ -1,21 +0,0 @@
-dnl SPDX-License-Identifier: GPL-2.0-or-later
-dnl Copyright (c) 2014 Fujitsu Ltd.
-dnl Author: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
-
-AC_DEFUN([LTP_CHECK_SYSCALL_FCNTL],[
-	AC_MSG_CHECKING([for fcntl f_owner_ex])
-	AC_COMPILE_IFELSE([AC_LANG_SOURCE([
-#define _GNU_SOURCE
-#include <fcntl.h>
-int main(void) {
-	struct f_owner_ex tst_own_ex;
-	return 0;
-}])],[has_f_owner_ex="yes"])
-
-if test "x$has_f_owner_ex" = xyes; then
-	AC_DEFINE(HAVE_STRUCT_F_OWNER_EX,1,[Define to 1 if you have struct f_owner_ex])
-	AC_MSG_RESULT(yes)
-else
-	AC_MSG_RESULT(no)
-fi
-])
diff --git a/testcases/kernel/syscalls/fcntl/fcntl31.c b/testcases/kernel/syscalls/fcntl/fcntl31.c
index f6f625e855..f5c4f83983 100644
--- a/testcases/kernel/syscalls/fcntl/fcntl31.c
+++ b/testcases/kernel/syscalls/fcntl/fcntl31.c
@@ -44,13 +44,11 @@ static void cleanup(void);
 static void setown_pid_test(void);
 static void setown_pgrp_test(void);
 
-#if defined(HAVE_STRUCT_F_OWNER_EX)
 static void setownex_tid_test(void);
 static void setownex_pid_test(void);
 static void setownex_pgrp_test(void);
 
 static struct f_owner_ex orig_own_ex;
-#endif
 
 static void signal_parent(void);
 static void check_io_signal(char *des);
@@ -68,9 +66,7 @@ static int pipe_fds[2];
 
 static void (*testfunc[])(void) = {
 	setown_pid_test, setown_pgrp_test,
-#if defined(HAVE_STRUCT_F_OWNER_EX)
 	setownex_tid_test, setownex_pid_test, setownex_pgrp_test
-#endif
 };
 
 char *TCID = "fcntl31";
@@ -122,14 +118,12 @@ static void setup(void)
 	if (pgrp_pid < 0)
 		tst_brkm(TBROK | TERRNO, cleanup, "getpgid() failed");
 
-#if defined(HAVE_STRUCT_F_OWNER_EX)
 	/* get original f_owner_ex info */
 	TEST(fcntl(test_fd, F_GETOWN_EX, &orig_own_ex));
 	if (TEST_RETURN < 0) {
 		tst_brkm(TFAIL | TTERRNO, cleanup,
 			 "fcntl get original f_owner_ex info failed");
 	}
-#endif
 
 	/* get original pid info */
 	TEST(fcntl(test_fd, F_GETOWN));
@@ -183,7 +177,6 @@ static void setown_pgrp_test(void)
 	}
 }
 
-#if defined(HAVE_STRUCT_F_OWNER_EX)
 static void setownex_cleanup(void)
 {
 	TEST(fcntl(test_fd, F_SETOWN_EX, &orig_own_ex));
@@ -245,7 +238,6 @@ static void setownex_pgrp_test(void)
 
 	setownex_cleanup();
 }
-#endif
 
 static void test_set_and_get_sig(int sig, char *des)
 {
-- 
2.50.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2 0/3] autotools: Remove old checks

[Li Wang via ltp]

For series:
Reviewed-by: Li Wang <liwang@redhat.com>

On Fri, Aug 8, 2025 at 7:01 PM Petr Vorel <pvorel@suse.cz> wrote:

> Changes v1->v2:
> * Fix compilation error missing endif
>
> Link to v1:
> https://patchwork.ozlabs.org/project/ltp/list/?series=468404&state=*
>
> Petr Vorel (3):
>   Remove m4/ltp-signalfd.m4
>   m4: lapi: Drop check for old libcap-devel
>   m4: fcntl31: Remove check for struct f_owner_ex
>
>  configure.ac                              |  2 --
>  include/lapi/capability.h                 |  8 --------
>  m4/ltp-cap.m4                             | 17 +----------------
>  m4/ltp-fcntl.m4                           | 21 ---------------------
>  m4/ltp-signalfd.m4                        | 17 -----------------
>  testcases/kernel/syscalls/fcntl/fcntl31.c |  8 --------
>  6 files changed, 1 insertion(+), 72 deletions(-)
>  delete mode 100644 m4/ltp-fcntl.m4
>  delete mode 100644 m4/ltp-signalfd.m4
>
> --
> 2.50.1
>
>
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
>
>

-- 
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2 0/3] autotools: Remove old checks

[Petr Vorel]

Hi all,

merged!
Li, Avinesh, thanks for your review.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp