Re: [LTP] [PATCH] NetNS test fixes

Subrata Modak
2010-05-09T14:17:58Z

On Fri, 2010-05-07 at 09:36 -0500, Serge E. Hallyn wrote:
> Quoting Dan Smith (danms@us.ibm.com):
> > SM> Can you please ack this patch.
> >
> > Ack the revised one below instead :)
> >
> > By the way, these tests appear to start up sshd for no reason other
> > than possibly checking that basic sockets work in the netns. Given
> > the frailty and required setup of the "ftp" test, I think it would be
> > better to replace it with a test using netcat and then yank the sshd
> > bits from the ping tests.
>
> Ack that.
>
> > Dan Smith
> > IBM Linux Technology Center
> > email: danms@us.ibm.com
> >
> > NetNS test fixes (v2)
> >
> > This patch fixes a couple of netns test issues that cause invalid failures
> > relating to exiting with a status variable that doesn't exist. It also
> > fixes an instance of inverted logic and a failure to exec sshd with the
> > full path (as required).
> >
> > Additionally, it makes the common child exec function more descriptive of
> > what it tried to do and why it failed to ease debugging.
> >
> > Changes in v2:
> > - Initialize status=0 at the top of child_1.sh to prevent overshadowing
> > a (meaningless) sshd failure
> >
> > Signed-off-by: Dan Smith <danms@us.ibm.com>
>
> Acked-by: Serge E. Hallyn <serue@us.ibm.com>

Thats Great. Thanks :-)

Regards--
Subrata

>
> thanks,
> -serge