From: Subrata Modak <subrata@linux.vnet.ibm.com>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: ltp-list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH] eventfd01: should to check ret in overflow_poll_test()
Date: Fri, 07 May 2010 11:16:42 +0530 [thread overview]
Message-ID: <1273211202.6042.0.camel@subratamodak.linux.ibm.com> (raw)
In-Reply-To: <q2o364299f41005061101h53710323s534939b9bf0d7087@mail.gmail.com>
On Thu, 2010-05-06 at 11:01 -0700, Garrett Cooper wrote:
> On Thu, May 6, 2010 at 2:25 AM, Shi Weihua <shiwh@cn.fujitsu.com> wrote:
> > We should to check the return value of trigger_eventfd_overflow()
> > in overflow_poll_test().
> >
> > Signed-off-by: Shi Weihua <shiwh@cn.fujitsu.com>
> > ---
> > diff --git a/testcases/kernel/syscalls/eventfd/eventfd01.c b/testcases/kernel/syscalls/eventfd/eventfd01.c
> > index 83eb86e..ce55746 100644
> > --- a/testcases/kernel/syscalls/eventfd/eventfd01.c
> > +++ b/testcases/kernel/syscalls/eventfd/eventfd01.c
> > @@ -602,7 +602,7 @@ static void overflow_poll_test(int evfd)
> > int ret;
> >
> > ret = trigger_eventfd_overflow(evfd, &fd, &ctx);
> > - if (fd == -1) {
> > + if (ret == -1) {
> > tst_resm(TBROK, "error triggering eventfd overflow");
> > return;
> > }
>
> Acked-by: Garrett Cooper <yanegomi@gmail.com>
Thanks. Just checked in.
Regards--
Subrata
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2010-05-07 5:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 9:25 [LTP] [PATCH] eventfd01: should to check ret in overflow_poll_test() Shi Weihua
2010-05-06 18:01 ` Garrett Cooper
2010-05-07 5:46 ` Subrata Modak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1273211202.6042.0.camel@subratamodak.linux.ibm.com \
--to=subrata@linux.vnet.ibm.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=yanegomi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox