From: Gowrishankar <gomuthuk@linux.vnet.ibm.com>
To: Linux Test Project <ltp-list@lists.sourceforge.net>
Cc: gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
Subject: [LTP] [PATCH 4/5] realtime: code cleanup on pi-test 5
Date: Thu, 27 May 2010 09:33:25 +0530 [thread overview]
Message-ID: <1274933006-4754-5-git-send-email-gomuthuk@linux.vnet.ibm.com> (raw)
In-Reply-To: <Gowrishankar <gomuthuk@linux.vnet.ibm.com>
From: gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
This patch cleans up the test so as to follow C coding style standards.
Signed-off-by: Gowrishankar <gowrishankar.m@in.ibm.com>
Tested-by: Gowrishankar <gowrishankar.m@in.ibm.com>
Acked-by: John Stultz <johnstul@us.ibm.com>
Acked-by: Darren Hart <dvhltc@us.ibm.com>
---
testcases/realtime/func/pi-tests/testpi-5.c | 76 ++++++++++++++-------------
1 files changed, 39 insertions(+), 37 deletions(-)
diff --git a/testcases/realtime/func/pi-tests/testpi-5.c b/testcases/realtime/func/pi-tests/testpi-5.c
index faf3d8d..b3ea6ef 100644
--- a/testcases/realtime/func/pi-tests/testpi-5.c
+++ b/testcases/realtime/func/pi-tests/testpi-5.c
@@ -30,6 +30,7 @@
*
*
* HISTORY
+ * 2010-04-22 Code cleanup by Gowrishankar
*
*
*****************************************************************************/
@@ -39,54 +40,55 @@
#include <string.h>
#include <unistd.h>
#include <librttest.h>
-pthread_mutex_t child_mutex;
+pthread_mutex_t child_mutex;
-void* child_thread (void* arg)
+void *child_thread(void *arg)
{
- int ret;
+ int ret;
- ret = pthread_mutex_lock(&child_mutex);
- if (ret != 0)
- printf("child thread: Failed to lock child_mutex: %d\n", ret);
- else
- printf("child_thread: got lock\n");
+ ret = pthread_mutex_lock(&child_mutex);
+ if (ret != 0)
+ printf("child thread: Failed to lock child_mutex: %d\n", ret);
+ else
+ printf("child_thread: got lock\n");
- sleep(2);
+ sleep(2);
- printf("child_thread: Trying to get lock 2nd time\n");
- ret = pthread_mutex_lock(&child_mutex);
- if (ret != 0)
- printf("child thread: Failed to lock child_mutex: %d\n", ret);
- else
- printf("child_thread: got lock 2nd time !!\n");
+ printf("child_thread: Trying to get lock 2nd time\n");
+ ret = pthread_mutex_lock(&child_mutex);
+ if (ret != 0)
+ printf("child thread: Failed to lock child_mutex: %d\n", ret);
+ else
+ printf("child_thread: got lock 2nd time !!\n");
- return NULL;
+ return NULL;
}
-int do_test(int argc, char ** argv)
+int do_test(int argc, char **argv)
{
- pthread_mutexattr_t mutexattr;
- int retc, protocol;
+ pthread_mutexattr_t mutexattr;
+ int retc, protocol;
- if (pthread_mutexattr_init(&mutexattr) != 0) {
- printf("Failed to init mutexattr\n");
- };
- if (pthread_mutexattr_setprotocol(&mutexattr, PTHREAD_PRIO_INHERIT) != 0) {
- printf("Can't set protocol prio inherit\n");
- }
- if (pthread_mutexattr_getprotocol(&mutexattr, &protocol) != 0) {
- printf("Can't get mutexattr protocol\n");
- } else {
- printf("protocol in mutexattr is %d\n", protocol);
- }
- if ((retc = pthread_mutex_init(&child_mutex, &mutexattr)) != 0) {
- printf("Failed to init mutex: %d\n", retc);
- }
+ if (pthread_mutexattr_init(&mutexattr) != 0)
+ printf("Failed to init mutexattr\n");
- create_other_thread(child_thread, NULL);
- join_threads();
-
- return 0;
+ if (pthread_mutexattr_setprotocol(&mutexattr,\
+ PTHREAD_PRIO_INHERIT) != 0)
+ printf("Can't set protocol prio inherit\n");
+
+ if (pthread_mutexattr_getprotocol(&mutexattr, &protocol) != 0)
+ printf("Can't get mutexattr protocol\n");
+ else
+ printf("protocol in mutexattr is %d\n", protocol);
+
+ retc = pthread_mutex_init(&child_mutex, &mutexattr);
+ if (retc != 0)
+ printf("Failed to init mutex: %d\n", retc);
+
+ create_other_thread(child_thread, NULL);
+ join_threads();
+
+ return 0;
}
#include "test-skeleton.c"
--
1.7.1
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2010-05-27 4:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Gowrishankar <gomuthuk@linux.vnet.ibm.com>
2010-05-27 4:03 ` [LTP] [PATCH 0/5] realtime: code cleanup on pi-tests to adapt C coding standard Gowrishankar
2010-05-28 7:32 ` Subrata Modak
2010-05-27 4:03 ` [LTP] [PATCH 1/5] realtime: code cleanup on pi-test 0 Gowrishankar
2010-05-27 4:03 ` [LTP] [PATCH 2/5] realtime: code cleanup on pi-test 1 Gowrishankar
2010-05-27 4:03 ` [LTP] [PATCH 3/5] realtime: code cleanup on pi-test 2 Gowrishankar
2010-05-27 4:03 ` Gowrishankar [this message]
2010-05-27 4:03 ` [LTP] [PATCH 5/5] realtime: code cleanup on pi-test 6 Gowrishankar
2010-05-27 4:11 ` [LTP] [PATCH 0/5] realtime: functional changes improved in pi-tests Gowrishankar
2010-05-28 7:31 ` Subrata Modak
2010-05-27 4:11 ` [LTP] [PATCH 1/6] realtime: reuse init_pi_mutex from librttest Gowrishankar
2010-05-27 4:11 ` [LTP] [PATCH 2/6] realtime: add test descriptions Gowrishankar
2010-05-27 4:11 ` [LTP] [PATCH 3/6] realtime: threads need not set cpu affinity while main does Gowrishankar
2010-05-27 4:11 ` [LTP] [PATCH 4/6] realtime: use busy_work_ms from librttest to burn cpu cycles Gowrishankar
2010-05-27 4:11 ` [LTP] [PATCH 5/6] realtime: remove thread_stop which is not used anywhere Gowrishankar
2010-05-27 4:11 ` [LTP] [PATCH 6/6] realtime: synchronization fixes for high priority noise thread Gowrishankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274933006-4754-5-git-send-email-gomuthuk@linux.vnet.ibm.com \
--to=gomuthuk@linux.vnet.ibm.com \
--cc=gowrishankar.m@linux.vnet.ibm.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox