From: Gowrishankar <gomuthuk@linux.vnet.ibm.com>
To: Linux Test Project <ltp-list@lists.sourceforge.net>
Cc: gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
Subject: [LTP] [PATCH 4/6] realtime: use busy_work_ms from librttest to burn cpu cycles
Date: Thu, 27 May 2010 09:41:24 +0530 [thread overview]
Message-ID: <1274933486-4876-5-git-send-email-gomuthuk@linux.vnet.ibm.com> (raw)
In-Reply-To: <Gowrishankar <gomuthuk@linux.vnet.ibm.com>
From: gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
Instead of lock/unlock of mutex to burn cpu cycles, we can use busy_work_ms
from librttest which is more explicit (burn cycles, not provide some
synchronization).
Also this patch removes the id increment since it is not used.
Signed-off-by: Gowrishankar <gowrishankar.m@in.ibm.com>
Tested-by: Gowrishankar <gowrishankar.m@in.ibm.com>
Acked-by: John Stultz <johnstul@us.ibm.com>
Acked-by: Darren Hart <dvhltc@us.ibm.com>
---
testcases/realtime/func/pi-tests/testpi-1.c | 24 ++++++------------------
testcases/realtime/func/pi-tests/testpi-2.c | 24 ++++++------------------
2 files changed, 12 insertions(+), 36 deletions(-)
diff --git a/testcases/realtime/func/pi-tests/testpi-1.c b/testcases/realtime/func/pi-tests/testpi-1.c
index 25541d7..71b01ec 100644
--- a/testcases/realtime/func/pi-tests/testpi-1.c
+++ b/testcases/realtime/func/pi-tests/testpi-1.c
@@ -81,7 +81,7 @@ pthread_mutex_t glob_mutex;
void *func_nonrt(void *arg)
{
struct thread *pthr = (struct thread *)arg;
- int i, j, tid = gettid();
+ int i, tid = gettid();
printf("Thread %d started running with priority %d\n", tid,\
pthr->priority);
@@ -97,11 +97,7 @@ void *func_nonrt(void *arg)
tid, i, pthr->policy, pthr->priority);
fflush(NULL);
}
- pthr->id++;
- for (j = 0; j < 5000; j++) {
- pthread_mutex_lock(&(pthr->mutex));
- pthread_mutex_unlock(&(pthr->mutex));
- }
+ busy_work_ms(1);
}
pthread_mutex_unlock(&glob_mutex);
return NULL;
@@ -110,7 +106,7 @@ void *func_nonrt(void *arg)
void *func_rt(void *arg)
{
struct thread *pthr = (struct thread *)arg;
- int i, j, tid = gettid();
+ int i, tid = gettid();
printf("Thread %d started running with prio %d\n", tid, pthr->priority);
pthread_barrier_wait(&barrier);
@@ -129,11 +125,7 @@ void *func_rt(void *arg)
tid, i, pthr->policy, pthr->priority);
fflush(NULL);
}
- pthr->id++;
- for (j = 0; j < 5000; j++) {
- pthread_mutex_lock(&(pthr->mutex));
- pthread_mutex_unlock(&(pthr->mutex));
- }
+ busy_work_ms(1);
}
pthread_mutex_unlock(&glob_mutex);
return NULL;
@@ -142,7 +134,7 @@ void *func_rt(void *arg)
void *func_noise(void *arg)
{
struct thread *pthr = (struct thread *)arg;
- int i, j, tid = gettid();
+ int i, tid = gettid();
printf("Noise Thread %d started running with prio %d\n", tid,
pthr->priority);
@@ -155,11 +147,7 @@ void *func_noise(void *arg)
pthr->priority);
fflush(NULL);
}
- pthr->id++;
- for (j = 0; j < 5000; j++) {
- pthread_mutex_lock(&(pthr->mutex));
- pthread_mutex_unlock(&(pthr->mutex));
- }
+ busy_work_ms(1);
}
return NULL;
}
diff --git a/testcases/realtime/func/pi-tests/testpi-2.c b/testcases/realtime/func/pi-tests/testpi-2.c
index eb00129..68dde44 100644
--- a/testcases/realtime/func/pi-tests/testpi-2.c
+++ b/testcases/realtime/func/pi-tests/testpi-2.c
@@ -83,7 +83,7 @@ pthread_mutex_t glob_mutex;
void *func_lowrt(void *arg)
{
struct thread *pthr = (struct thread *)arg;
- int i, j, tid = gettid();
+ int i, tid = gettid();
printf("Thread %d started running with priority %d\n", tid,\
pthr->priority);
@@ -99,11 +99,7 @@ void *func_lowrt(void *arg)
tid, i, pthr->policy, pthr->priority);
fflush(NULL);
}
- pthr->id++;
- for (j = 0; j < 5000; j++) {
- pthread_mutex_lock(&(pthr->mutex));
- pthread_mutex_unlock(&(pthr->mutex));
- }
+ busy_work_ms(1);
}
pthread_mutex_unlock(&glob_mutex);
return NULL;
@@ -112,7 +108,7 @@ void *func_lowrt(void *arg)
void *func_rt(void *arg)
{
struct thread *pthr = (struct thread *)arg;
- int i, j, tid = gettid();
+ int i, tid = gettid();
printf("Thread %d started running with prio %d\n", tid, pthr->priority);
pthread_barrier_wait(&barrier);
@@ -131,11 +127,7 @@ void *func_rt(void *arg)
tid, i, pthr->policy, pthr->priority);
fflush(NULL);
}
- pthr->id++;
- for (j = 0; j < 5000; j++) {
- pthread_mutex_lock(&(pthr->mutex));
- pthread_mutex_unlock(&(pthr->mutex));
- }
+ busy_work_ms(1);
}
pthread_mutex_unlock(&glob_mutex);
return NULL;
@@ -144,7 +136,7 @@ void *func_rt(void *arg)
void *func_noise(void *arg)
{
struct thread *pthr = (struct thread *)arg;
- int i, j, tid = gettid();
+ int i, tid = gettid();
printf("Noise Thread %d started running with prio %d\n", tid,\
pthr->priority);
@@ -157,11 +149,7 @@ void *func_noise(void *arg)
pthr->priority);
fflush(NULL);
}
- pthr->id++;
- for (j = 0; j < 5000; j++) {
- pthread_mutex_lock(&(pthr->mutex));
- pthread_mutex_unlock(&(pthr->mutex));
- }
+ busy_work_ms(1);
}
return NULL;
}
--
1.7.1
------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2010-05-27 4:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Gowrishankar <gomuthuk@linux.vnet.ibm.com>
2010-05-27 4:03 ` [LTP] [PATCH 0/5] realtime: code cleanup on pi-tests to adapt C coding standard Gowrishankar
2010-05-28 7:32 ` Subrata Modak
2010-05-27 4:03 ` [LTP] [PATCH 1/5] realtime: code cleanup on pi-test 0 Gowrishankar
2010-05-27 4:03 ` [LTP] [PATCH 2/5] realtime: code cleanup on pi-test 1 Gowrishankar
2010-05-27 4:03 ` [LTP] [PATCH 3/5] realtime: code cleanup on pi-test 2 Gowrishankar
2010-05-27 4:03 ` [LTP] [PATCH 4/5] realtime: code cleanup on pi-test 5 Gowrishankar
2010-05-27 4:03 ` [LTP] [PATCH 5/5] realtime: code cleanup on pi-test 6 Gowrishankar
2010-05-27 4:11 ` [LTP] [PATCH 0/5] realtime: functional changes improved in pi-tests Gowrishankar
2010-05-28 7:31 ` Subrata Modak
2010-05-27 4:11 ` [LTP] [PATCH 1/6] realtime: reuse init_pi_mutex from librttest Gowrishankar
2010-05-27 4:11 ` [LTP] [PATCH 2/6] realtime: add test descriptions Gowrishankar
2010-05-27 4:11 ` [LTP] [PATCH 3/6] realtime: threads need not set cpu affinity while main does Gowrishankar
2010-05-27 4:11 ` Gowrishankar [this message]
2010-05-27 4:11 ` [LTP] [PATCH 5/6] realtime: remove thread_stop which is not used anywhere Gowrishankar
2010-05-27 4:11 ` [LTP] [PATCH 6/6] realtime: synchronization fixes for high priority noise thread Gowrishankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274933486-4876-5-git-send-email-gomuthuk@linux.vnet.ibm.com \
--to=gomuthuk@linux.vnet.ibm.com \
--cc=gowrishankar.m@linux.vnet.ibm.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox