Re: [LTP] [PATCH][runtest/fs] fix issue where growfiles tests still not creating temp files in directory specified by TMPDIR as expected

[Subrata Modak <subrata@linux.vnet.ibm.com>]

On Fri, 2010-06-11 at 15:40 -0700, Henry Yei wrote: 
> This is an updated patch which changes the arguments for gf12, gf13
> test to use the named pipes created by mkfifo properly, rather then
> the ordinary file created by and incorporates the previous changes.
> Hopefully that catches everything, these fs tests are quite hard to
> interpret.
> 
> Henry Yei <hyei@mvista.com>

Thanks.

Regards--
Subrata

> 
> On Wed, Jun 9, 2010 at 6:32 PM, Henry Yei <hyei@mvista.com> wrote:
> > On Wed, Jun 9, 2010 at 6:30 PM, Henry Yei <hyei@mvista.com> wrote:
> >> Hello,
> >>
> >> A previous patch that attempts to force tests to use the TMPDIR env
> >> variable is incomplete. This patch fixes growfiles test arguments in
> >> the fs scenario.
> >>
> >> Scripts which use growfiles with command-line file names are not performing the
> >> tests in the expected target directory. When file names are provided on the
> >> growfiles command line, they are taken relative to the cwd and not the -d
> >> auto_dir passed on the command line. This renders many of the test scripts in
> >> runtests ineffective in that the tests are not being performed on the expected
> >> filesystem.
> >>
> >> For example, the first line of the fs scenario reads:
> >>
> >> gf01 growfiles -B 800000 -W gf01 -b -e 1 -u -i 0 -L 20 -w -C 1 -l -I r -T 10
> >> glseek20 glseek20.2 -d $TMPDIR
> >>
> >> The -d $TMPDIR construct is almost always used in the scripts to point to the
> >> filesystem under test. However, the presence of the
> >> glseek20 glseek20.2 command line parameters constitute full file names from the
> >> test's view, so they will be used as-is (in the current working directory) as
> >> opposed to $TMPDIR/glseek20 or $TMPDIR/glseek20.2 as expected by the script.
> >>
> >> To get the desired behavior, here are the key switches:
> >>
> >> -f specifies the 'auto_file' which is the base file name (gf is used if it's
> >> missing)
> >>
> >> -d specifies the 'auto_dir' to be used ('.' is used if it's missing)
> >>
> >> -S specifies the number of 'auto seq' files to be used. These files are of the
> >> form: "%s/%s%d" using auto_dir, auto_file, file_number.
> >>
> >>
> >> Signed-off-by: Henry Yei <hyei@mvista.com>
> >>
> >
> > Patch for review now attached!
> >
> > Henry Yei <hyei@mvista.com>
> >
> ------------------------------------------------------------------------------
> ThinkGeek and WIRED's GeekDad team up for the Ultimate 
> GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
> lucky parental unit.  See the prize list and enter to win: 
> http://p.sf.net/sfu/thinkgeek-promo
> _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list


------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate 
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
lucky parental unit.  See the prize list and enter to win: 
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list