Re: [LTP] Patch to record kernel dump message to each testcases log

hake huang
2010-10-13T04:38:31Z

[-- Attachment #1.1: Type: text/plain, Size: 1823 bytes --]

Hi

I see this simple solution is no quite fit. But the kernel dump message for
each test case is necessary for analysing. I can work on this further, with
below help:
1. Where can I find the reason for the IIRC break?
2. Can it be an option to avoid the size limitation on some embedded
system?
3. A kind of seperating tag is needed for kernel message, right? e.g
<kernel_dump_start>dump message<kernel_dump_end>
4. I see in ltp-pan.c the file descriptors, terminals are changed in child
process. if the system(3) has problem, the worst cases is there are no
kernel messge output in parent process, but the pan can still function well.

if not use system(3), can you give your suggestion on this, exec(3) seems to
have the same problem as system(3)?

Regards,

Hake

2010/10/13 Garrett Cooper <yanegomi@gmail.com>

> On Tue, Oct 12, 2010 at 5:56 AM, hake huang <hakehuang@gmail.com> wrote:
> > Hi,
> >
> > I wnat LTP to record the kernel dump message during each test case, and I
> > make a patch for this. Any comments?
>
> Low:
> 1. This will break existing functionality (IIRC) with runltp provided
> by Subrata (CCed for comment).
>
> Medium:
> 2. It will bloat logs output on embedded systems / systems with limited
> space.
> 3. It could have other potential unwanted side-effects with tests
> and/or system services (in particular because some people on the list
> have been executing LTP on production systems, not testbed machines...
> even though I argue that's their mistake).
>
> High:
> 4. The change would confuse end-users.
> 5. The change would break scripts which parse the output in different
> ways from what you intend.
> 6. Using system(3) to execute a program could yield some unintended
> side-effects with file descriptors, terminal handling, process
> wait(2)ing, etc.
>
> Thanks,
> -Garrett
>

[-- Attachment #1.2: Type: text/html, Size: 2332 bytes --]

[-- Attachment #2: Type: text/plain, Size: 369 bytes --]

------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3.
Spend less time writing and rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]