Re: [LTP] Patch to record kernel dump message to each testcases log

Garrett Cooper
2010-10-12T20:21:23Z

On Tue, Oct 12, 2010 at 5:56 AM, hake huang <hakehuang@gmail.com> wrote:
> Hi,
>
> I wnat LTP to record the kernel dump message during each test case, and I
> make a patch for this. Any comments?

Low:
1. This will break existing functionality (IIRC) with runltp provided
by Subrata (CCed for comment).

Medium:
2. It will bloat logs output on embedded systems / systems with limited space.
3. It could have other potential unwanted side-effects with tests
and/or system services (in particular because some people on the list
have been executing LTP on production systems, not testbed machines...
even though I argue that's their mistake).

High:
4. The change would confuse end-users.
5. The change would break scripts which parse the output in different
ways from what you intend.
6. Using system(3) to execute a program could yield some unintended
side-effects with file descriptors, terminal handling, process
wait(2)ing, etc.

Thanks,
-Garrett