public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: Caspar Zhang <caspar@casparzhang.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] madvise05: new testcase for Oops in madvise_willneed
Date: Wed, 6 Aug 2014 03:42:52 -0400 (EDT)	[thread overview]
Message-ID: <1295578079.3016213.1407310972515.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <53E11A03.5000704@casparzhang.com>



----- Original Message -----
> From: "Caspar Zhang" <caspar@casparzhang.com>
> To: "Jan Stancek" <jstancek@redhat.com>, ltp-list@lists.sourceforge.net
> Sent: Tuesday, 5 August, 2014 7:53:07 PM
> Subject: Re: [LTP] [PATCH] madvise05: new testcase for Oops in madvise_willneed
> 
> On 08/05/2014 10:45 PM, Jan Stancek wrote:
> > This is a regression test for madvise(2) system call. It tests
> > kernel for NULL ptr deref Oops fixed by:
> >    commit ee53664bda169f519ce3c6a22d378f0b946c8178
> >    Author: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> >    Date:   Fri Dec 20 15:10:03 2013 +0200
> >      mm: Fix NULL pointer dereference in madvise(MADV_WILLNEED) support
> >
> > Signed-off-by: Jan Stancek <jstancek@redhat.com>
> > ---
> >   runtest/syscalls                              |    1 +
> >   testcases/kernel/syscalls/.gitignore          |    1 +
> >   testcases/kernel/syscalls/madvise/madvise05.c |   81
> >   +++++++++++++++++++++++++
> >   3 files changed, 83 insertions(+), 0 deletions(-)
> >   create mode 100644 testcases/kernel/syscalls/madvise/madvise05.c
> >

> Is MADV_WILLNEED available on all releases? If yes, the new case looks
> good to me.

It was introduced before 2.4, so I assume it's available on releases
made after 2002. Also none of other madvise testcases checks/tests for it.

However, I noticed that older kernels fail with EBADF, if there is no
backing file. I'll fix that and send v2.

Regards,
Jan


------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls. 
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

      reply	other threads:[~2014-08-06  7:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-05 14:45 [LTP] [PATCH] madvise05: new testcase for Oops in madvise_willneed Jan Stancek
2014-08-05 14:58 ` chrubis
2014-08-05 17:53 ` Caspar Zhang
2014-08-06  7:42   ` Jan Stancek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295578079.3016213.1407310972515.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=caspar@casparzhang.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox