Re: [LTP] selinux-testsuite has moved

[Stephen Smalley <sds@tycho.nsa.gov>]

On Mon, 2011-04-25 at 12:38 -0700, Garrett Cooper wrote:
> On Apr 25, 2011, at 6:32 AM, Stephen Smalley <sds@tycho.nsa.gov> wrote:
> > At present we see no benefit, only cost, to maintaining the selinux
> > testsuite in the ltp as it is regularly broken by unrelated changes
> > elsewhere in the ltp and as it is not truly integrated into the ltp (you
> > have to perform separate steps to build and run it).  In comparison, we
> > don't have to worry about unrelated changes breaking the standalone
> > selinux testsuite, and it is certainly no harder to do this:
> > 
> > git clone git://git.kernel.org/pub/scm/tests/selinux-testsuite
> > cd selinux-testsuite
> > sudo make test
> > 
> > than to do this:
> > 
> > git clone git://ltp.git.sourceforge.net/gitroot/ltp/ltp
> > cd ltp
> > make autotools
> > ./configure
> > make all
> > make install
> > cd testcases/kernel/security/selinux-testsuite
> > make all
> > make install
> > cd /opt/ltp
> > ./testscripts/test_selinux.sh
> > 
> > If the selinux testsuite were fully integrated into the ltp (e.g. built
> > and run by default if SELinux is enabled on the system), then that might
> > be more worthwhile to keep it as part of the ltp.  But in the 6 years
> > since it was added to the ltp, that hasn't happened.
> 
> Do what's easiest for you guys to maintain upstream; what you suggested makes sense: pull from git and run selinux as-is. The twist I'm proposing here is as follows:
> 1. The selinux test suite needs to be made modular and portable. I'll provide you with autoconf/other patches sometime after I get back from vacation on friday.
> 2. I'll add logic to pull from git in ltp, which means the following: releases will come with the selinux test suite; archives and other non-release mechanisms won't. Thus, if you want to run the selinux testcases, you will need git, and will have to specify --with-selinux=yes when running configure, etc.
> 
> Sound ok?

Not sure what modularity or portability problems you see in the
testsuite, but I think autotools would be overkill and just make
maintenance harder.  If by modularity you mean the ability to run tests
individually, that is already possible, and if by portability you mean
the ability to build and run the tests on the various architectures, I
believe that also is already covered.  We certainly don't have to
concern ourselves with portability to other OSes, as the selinux
testsuite is by definition specific to Linux.

-- 
Stephen Smalley
National Security Agency


------------------------------------------------------------------------------
WhatsUp Gold - Download Free Network Management Software
The most intuitive, comprehensive, and cost-effective network 
management toolset available today.  Delivers lowest initial 
acquisition cost and overall TCO of any competing solution.
http://p.sf.net/sfu/whatsupgold-sd
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list