From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v1 1/4] lib: add new cgroup test API
Date: Wed, 27 May 2020 05:15:20 -0400 (EDT) [thread overview]
Message-ID: <1306372061.13772311.1590570920909.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAEemH2e6Hr7JmdV02P=8SyiVK-q5fHj7=RkF_R8fM+m9b3PrBg@mail.gmail.com>
----- Original Message -----
> On Wed, May 27, 2020 at 3:40 PM Jan Stancek <jstancek@redhat.com> wrote:
>
> >
> >
> >
> > ----- Original Message -----
> > > +
> > > +void tst_cgroup_mem_set_maxbytes(long memsz)
> > > +{
> > > + tst_cgroup_move_current(TST_CGROUP_MEMCG);
> >
> > It seems a bit unexpected, that setting a limit also moves current
> > process to cgroup. If test forks two processes, it has to set maxbytes
> > twice, to get the desired side-effect.
> >
>
> Yes, I didn't aware of that before.
> Maybe we can remove the tst_cgroup_move_current() from here and invoke it
> additionally?
Agreed, some cpuset tests already do it that way.
next prev parent reply other threads:[~2020-05-27 9:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 3:14 [LTP] [PATCH v1 1/4] lib: add new cgroup test API Li Wang
2020-05-27 3:14 ` [LTP] [PATCH v1 2/4] mem: take use of new cgroup API Li Wang
2020-05-27 7:45 ` Jan Stancek
2020-05-27 10:10 ` Li Wang
2020-05-27 3:14 ` [LTP] [PATCH v1 3/4] mem: remove the old " Li Wang
2020-05-27 3:14 ` [LTP] [PATCH v1 4/4] mm: add cpuset01 to runtest file Li Wang
2020-05-27 7:40 ` [LTP] [PATCH v1 1/4] lib: add new cgroup test API Jan Stancek
2020-05-27 8:00 ` Li Wang
2020-05-27 9:15 ` Jan Stancek [this message]
2020-05-27 7:47 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306372061.13772311.1590570920909.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox