From: Kang Kai <kai.kang@windriver.com>
To: jstancek@redhat.com
Cc: ltp-list@lists.sourceforge.net
Subject: [LTP] [PATCH] mq_open/16-1: use tmp file to share info
Date: Thu, 6 Sep 2012 13:29:10 +0800 [thread overview]
Message-ID: <1346909350-716-2-git-send-email-kai.kang@windriver.com> (raw)
In-Reply-To: <1346909350-716-1-git-send-email-kai.kang@windriver.com>
In this test case, it uses a variable to share data between child and
parent processes. But after fork there is a copy of the variable in
child process and modify it will not affect the variable in the parent
process. Then when the child process call mq_open() before parent
process, the case will fail.
Use tmp file to replace the variable. Any modification in child process
can be seen in parent process.
Signed-off-by: Kang Kai <kai.kang@windriver.com>
---
.../conformance/interfaces/mq_open/16-1.c | 39 +++++++++++++++++++-
1 files changed, 37 insertions(+), 2 deletions(-)
diff --git a/testcases/open_posix_testsuite/conformance/interfaces/mq_open/16-1.c b/testcases/open_posix_testsuite/conformance/interfaces/mq_open/16-1.c
index e07ce86..eadac81 100644
--- a/testcases/open_posix_testsuite/conformance/interfaces/mq_open/16-1.c
+++ b/testcases/open_posix_testsuite/conformance/interfaces/mq_open/16-1.c
@@ -20,9 +20,11 @@
* this is fine (will have some false positives, but no false negatives).
*/
+#include <sys/mman.h>
#include <sys/stat.h>
#include <sys/types.h>
#include <sys/wait.h>
+#include <errno.h>
#include <fcntl.h>
#include <mqueue.h>
#include <signal.h>
@@ -32,11 +34,15 @@
#include "posixtest.h"
#define NAMESIZE 50
+#define TNAME "mq_open/16-1.c"
int main()
{
char qname[NAMESIZE];
+ char fname[NAMESIZE];
int pid, succeeded = 0;
+ int fd;
+ void *pa = NULL;
mqd_t childqueue, queue;
/*
@@ -47,6 +53,26 @@ int main()
sprintf(qname, "/mq_open_16-1_%d", getpid());
+ sprintf(fname, "/tmp/pts_mq_open_16_1_%d", getpid());
+ unlink(fname);
+ fd = open(fname, O_CREAT | O_RDWR | O_EXCL,
+ S_IRUSR | S_IWUSR);
+ if (fd == -1) {
+ printf(TNAME " Error at open(): %s\n", strerror(errno));
+ exit(PTS_UNRESOLVED);
+ }
+ /* file is empty now, will cause "Bus error" */
+ write(fd, fname, sizeof(int));
+ unlink(fname);
+
+ pa = mmap(NULL, sizeof(int), PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0);
+ if (pa == MAP_FAILED) {
+ printf(TNAME " Error at mmap: %s\n", strerror(errno));
+ close(fd);
+ exit(PTS_FAIL);
+ }
+ *(int *)pa = 0;
+
pid = fork();
if (pid == 0) {
sigset_t mask;
@@ -63,7 +89,7 @@ int main()
childqueue = mq_open(qname, O_CREAT | O_EXCL | O_RDWR,
S_IRUSR | S_IWUSR, NULL);
if (childqueue != (mqd_t) -1) {
- succeeded++;
+ ++*(int *)pa;
#ifdef DEBUG
printf("mq_open() in child succeeded\n");
} else {
@@ -80,7 +106,7 @@ int main()
queue = mq_open(qname, O_CREAT | O_EXCL | O_RDWR,
S_IRUSR | S_IWUSR, NULL);
if (queue != (mqd_t) -1) {
- succeeded++;
+ ++*(int *)pa;
#ifdef DEBUG
printf("mq_open() in parent succeeded\n");
} else {
@@ -94,6 +120,8 @@ int main()
mq_close(queue);
mq_close(childqueue);
mq_unlink(qname);
+ close(fd);
+ munmap(pa, sizeof(int));
return PTS_UNRESOLVED;
}
@@ -101,17 +129,24 @@ int main()
mq_close(childqueue);
mq_unlink(qname);
+ succeeded = *(int *)pa;
if (succeeded == 0) {
printf("Test FAILED - mq_open() never succeeded\n");
+ close(fd);
+ munmap(pa, sizeof(int));
return PTS_FAIL;
}
if (succeeded > 1) {
printf("Test FAILED - mq_open() succeeded twice\n");
+ close(fd);
+ munmap(pa, sizeof(int));
return PTS_FAIL;
}
printf("Test PASSED\n");
+ close(fd);
+ munmap(pa, sizeof(int));
return PTS_PASS;
}
--
1.7.5.4
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2012-09-06 5:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 5:29 [LTP] [PATCH] V2: mq_open/16-1: use tmp file to share info Kang Kai
2012-09-06 5:29 ` Kang Kai [this message]
2012-09-06 8:08 ` [LTP] [PATCH] " Jan Stancek
2012-09-06 9:45 ` Kang Kai
-- strict thread matches above, loose matches on Subject: below --
2012-09-06 9:50 [LTP] [PATCH] V3: " Kang Kai
2012-09-06 9:50 ` [LTP] [PATCH] " Kang Kai
2012-09-13 1:20 ` Wanlong Gao
2012-09-04 9:52 Kang Kai
2012-09-06 1:17 ` Wanlong Gao
2012-09-06 3:23 ` Kang Kai
2012-08-06 8:45 Kang Kai
2012-08-06 7:49 Kang Kai
2012-08-06 8:06 ` Kang Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346909350-716-2-git-send-email-kai.kang@windriver.com \
--to=kai.kang@windriver.com \
--cc=jstancek@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox