From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] move_pages04: fix zero page status code for kernels >= 4.3
Date: Thu, 6 Oct 2016 03:24:45 -0400 (EDT) [thread overview]
Message-ID: <1351583701.742495.1475738685339.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20161005154735.GE23476@rei.lan>
----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp@lists.linux.it
> Sent: Wednesday, 5 October, 2016 5:47:35 PM
> Subject: Re: [LTP] [PATCH] move_pages04: fix zero page status code for kernels >= 4.3
>
> Hi!
> > - if (status[UNTOUCHED_PAGE] == -ENOENT)
> > - tst_resm(TPASS, "status[%d] set to expected -ENOENT",
> > + if (status[UNTOUCHED_PAGE] == exp_status)
> > + tst_resm(TPASS, "status[%d] has expected value",
> > UNTOUCHED_PAGE);
> > else
> > - tst_resm(TFAIL, "status[%d] is %d", UNTOUCHED_PAGE,
> > - status[UNTOUCHED_PAGE]);
> > + tst_resm(TFAIL, "status[%d] is %d, expected %d",
> > + UNTOUCHED_PAGE, status[UNTOUCHED_PAGE],
> > + exp_status);
>
> It would be a bit better to print the errno with tst_strerrno() in both
> cases. I.e. tst_strerrno(-exp_status) and
> tst_strerrno(-status[UNTOUCHED_PAGE]) otherwise this looks obviously
> fine.
Pushed with your ack and suggested changes.
Regards,
Jan
>
> --
> Cyril Hrubis
> chrubis@suse.cz
>
prev parent reply other threads:[~2016-10-06 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 13:43 [LTP] [PATCH] move_pages04: fix zero page status code for kernels >= 4.3 Jan Stancek
2016-10-05 15:47 ` Cyril Hrubis
2016-10-06 7:24 ` Jan Stancek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351583701.742495.1475738685339.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox