Re: [LTP] [PATCH] use inotify_init1(0) for inotify tests on aarch64

[Jan Stancek <jstancek@redhat.com>]

----- Original Message -----
> From: "Jeffrey Bastian" <jbastian@redhat.com>
> To: ltp-list@lists.sourceforge.net
> Sent: Tuesday, 4 February, 2014 11:44:00 PM
> Subject: [LTP] [PATCH] use inotify_init1(0) for inotify tests on aarch64
> 
> aarch64 (and possibly other new architectures) does not implement
> the __ARCH_WANT_SYSCALL_NO_FLAGS syscalls, so use inotify_init1(0)
> instead of inotify_init(void)
> 
> Signed-off-by: Jeffrey Bastian <jbastian@redhat.com>

Looks good to me.

Reviewed-by: Jan Stancek <jstancek@redhat.com>

Regards,
Jan

> ---
>  testcases/kernel/syscalls/inotify/inotify.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/testcases/kernel/syscalls/inotify/inotify.h
> b/testcases/kernel/syscalls/inotify/inotify.h
> index e396947c4f98..68fe3b5f6426 100644
> --- a/testcases/kernel/syscalls/inotify/inotify.h
> +++ b/testcases/kernel/syscalls/inotify/inotify.h
> @@ -30,8 +30,13 @@
>  
>  /* inotify(7) wrappers */
>  
> +#if __NR_inotify_init != __LTP__NR_INVALID_SYSCALL
>  #define	myinotify_init() \
>  	syscall(__NR_inotify_init)
> +#else
> +#define	myinotify_init() \
> +	syscall(__NR_inotify_init1, 0)
> +#endif
>  
>  #define	myinotify_add_watch(fd, pathname, mask)	\
>  	syscall(__NR_inotify_add_watch, fd, pathname, mask)
> --
> 1.8.3.1
> 
> 
> ------------------------------------------------------------------------------
> Managing the Performance of Cloud-Based Applications
> Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
> Read the Whitepaper.
> http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
> 

------------------------------------------------------------------------------
Managing the Performance of Cloud-Based Applications
Take advantage of what the Cloud has to offer - Avoid Common Pitfalls.
Read the Whitepaper.
http://pubads.g.doubleclick.net/gampad/clk?id=121051231&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list