Re: [LTP] [PATCH v2] mem/oom: fixed a cpuset error

Zhouping Liu
2013-04-27T06:35:01Z

----- Original Message -----
> From: "Mike Frysinger" <vapier@gentoo.org>
> To: ltp-list@lists.sourceforge.net
> Cc: "Zhouping Liu" <zliu@redhat.com>
> Sent: Saturday, April 27, 2013 2:04:32 PM
> Subject: Re: [LTP] [PATCH v2] mem/oom: fixed a cpuset error
>
> On Saturday 27 April 2013 00:23:14 Zhouping Liu wrote:
> > The reason is that node0 only contains all CPUs, no any memory,
>
> no any memory -> no memory

OK.

>
> > and node1 contains all memory, but no CPUs, in the previous codes,
>
> change "CPUs, in" to "CPUs. In"

OK.

>
> > we only do cpuset testing on a independent node, which caused the
>
> a -> an

OK.

>
> > sub-cpuset cgroup only contains CPUs or memory in one node, but
>
> only contains -> to only contain

why 'contain', I think it should be 'contains', isn't it?

>
> > that's not permitted in the special machine. The patch fixed it.
>
> what is a "special machine" ?

the special machine is that it has such nodes(describe above),
in which there's only CPUs or memory.

how about this:

"that's not permitted in the such above special machine."

>
> also, generally there's no need to say "The patch fixed it". the fact that
> you've described a bug and have a patch implies that this fixes things.
>
> > + tst_resm(TINFO, "None CPUs in the node%ld", nd);
>
> i think you mean "no" instead of "None"
>
> > + tst_resm(TINFO, "Only use CPU0 in the cpuset cgroup "
> > + "for the special scenario");
>
> what is "the special scenario" ?

the special scenario is "no CPUs in the node%ld", I think it's clear in log message.

>
> > mount_mem("cpuset", "cpuset", NULL, CPATH, CPATH_NEW);
> > - if (is_numa(cleanup) > 0)
> > - /* For NUMA system, using the first node for cpuset.mems */
> > - write_cpusets(get_a_numa_node(cleanup));
> > - else
> > - /* For nonNUMA system, using node0 for cpuset.mems */
> > - write_cpusets(0);
> > +
> > + /*
> > + * Not any nodes contain memory, so using get_allowed_nodes(NH_MEMS)
>
> "Not any" -> "No"

it's not that meaning, what I meant here is that there's not any nodes contain
memory in a NUMA system, Some nodes contain memory, but some nodes don't.

>
> "using" -> "use"

OK.

>
> > + * to get a memory node, the operation also applies to Non-NUMA
>
> change the ", the" to ". This".

OK

>
> > + * system.
>
> systems.
>
> > + /*
>
> looks like you mixed spaces & tabs. only use tabs.

OK.

>
> > + * Not any nodes contain memory, so using get_allowed_nodes(NH_MEMS)
> > + * to get a memory node, the operation also applies to Non-NUMA
> > + * system.
>
> same comments about the grammar here as above
> -mike
>

--
Thanks,
Zhouping