[LTP] [PATCH] Fix mmap01 testcase on hppa architecture

[Jan Stancek <jstancek@redhat.com>]

----- Original Message -----
> On 13.06.2017 13:18, Jan Stancek wrote:
> >> The mmap() syscall to map a file at any given page-aligned address (via
> >> the
> >> MAP_FIXED flag) can fail on the hppa architecture due to cache colouring
> >> requirements of the architecture.
> >>
> >> This patch drops the MAP_FIXED flag and thus maps the file instead at
> >> some convenient address based on the hint as given by the addr
> >> parameter.
> > 
> > It looks like we don't need addr at all. Test is remapping part
> > of heap with MAP_FIXED, which looks risky. I'd drop that page
> > initialisation inside heap too. Now, without MAP_FIXED, it's
> > just completely unrelated page. What do you think?
> 
> Yes, that's probably the best choice.
> The original code tries to initialize the area where the file is going
> to be mapped with non-zero values to be able to check if after the mapping
> the memory area beyond the EOF was zero-initialized by the kernel.
> This part of the check was already changed by my initial patch, with
> your suggestion we would now drop the initialization completely.
> I think your suggestion is fair.
> 
> New patch is attached.

Pushed.

Thanks,
Jan