public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: Vinson Lee <vlee@freedesktop.org>, Zhouping Liu <zliu@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] setgid03.c: Fix build.
Date: Fri, 13 Sep 2013 07:22:26 -0400 (EDT)	[thread overview]
Message-ID: <1378015317.12865344.1379071346297.JavaMail.root@redhat.com> (raw)
In-Reply-To: <1379017479-2396-1-git-send-email-vlee@freedesktop.org>





----- Original Message -----
> From: "Vinson Lee" <vlee@freedesktop.org>
> To: ltp-list@lists.sourceforge.net
> Sent: Thursday, 12 September, 2013 10:24:39 PM
> Subject: [LTP] [PATCH] setgid03.c: Fix build.
> 
> From: Vinson Lee <vlee@twitter.com>
> 
> This patch fixes build errors introduced with commit
> 7dc42c97696f135e1fef92e612ecc66bf8d74318.
> 
> setgid03.c:36:23: error: static declaration of ‘getpwnam’ follows non-static
> declaration
> In file included from setgid03.c:24:0:
> /usr/include/pwd.h:117:23: note: previous declaration of ‘getpwnam’ was here
> setgid03.c:39:1: error: duplicate ‘static’
> setgid03.c:40:1: error: duplicate ‘static’
> 
> Signed-off-by: Vinson Lee <vlee@twitter.com>

Committed.
Zhouping I added your signed-off-by to this patch as it was identical.

Thank you,
Jan

> ---
>  testcases/kernel/syscalls/setgid/setgid03.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/setgid/setgid03.c
> b/testcases/kernel/syscalls/setgid/setgid03.c
> index 8b71401..8c76556 100644
> --- a/testcases/kernel/syscalls/setgid/setgid03.c
> +++ b/testcases/kernel/syscalls/setgid/setgid03.c
> @@ -33,11 +33,11 @@ int TST_TOTAL = 1;
>  
>  static char ltpuser1[] = "nobody";
>  static char root[] = "root";
> -static struct passwd *getpwnam(), *ltpuser1pwent, *rootpwent;
> +static struct passwd *ltpuser1pwent, *rootpwent;
>  static gid_t mygid;
>  
> -static static void setup(void);
> -static static void cleanup(void);
> +static void setup(void);
> +static void cleanup(void);
>  
>  int main(int ac, char **av)
>  {
> --
> 1.8.1.2
> 
> 
> ------------------------------------------------------------------------------
> How ServiceNow helps IT people transform IT departments:
> 1. Consolidate legacy IT systems to a single system of record for IT
> 2. Standardize and globalize service processes across IT
> 3. Implement zero-touch automation to replace manual, redundant tasks
> http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
> 

------------------------------------------------------------------------------
How ServiceNow helps IT people transform IT departments:
1. Consolidate legacy IT systems to a single system of record for IT
2. Standardize and globalize service processes across IT
3. Implement zero-touch automation to replace manual, redundant tasks
http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

      reply	other threads:[~2013-09-13 11:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-12 20:24 [LTP] [PATCH] setgid03.c: Fix build Vinson Lee
2013-09-13 11:22 ` Jan Stancek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378015317.12865344.1379071346297.JavaMail.root@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=vlee@freedesktop.org \
    --cc=zliu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox