From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 4/6] lib: extend PATH as part of test setup
Date: Wed, 11 Oct 2017 03:45:59 -0400 (EDT) [thread overview]
Message-ID: <1402903291.28351700.1507707959540.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20171010151852.GA12028@rei>
----- Original Message -----
> I do not like the strcat() function much, I would have probably handled
> these with asprintf();
>
> if (old_path)
> SAFE_ASPRINTF(&new_path, "%s::%s", old_path, start_dir);
> else
> SAFE_ASPRINTF(&new_path, "::%s", start_dir);
This makes it simpler, I've modified it to use SAFE_ASPRINTF.
>
>
> The rest of the patchset looks good.
I pushed all with your ACK.
>
> BTW, we should also drop the note about setting $PATH from the
> documentation once this is merged.
Or tweak it to say, it's no longer necessary for newlib tests.
Regards,
Jan
next prev parent reply other threads:[~2017-10-11 7:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 15:05 [LTP] [PATCH 1/6] lib: add LTP_IPC_PATH to env. variables by default Jan Stancek
2017-10-10 15:05 ` [LTP] [PATCH 2/6] lib: move tst_get_startwd() to old_tmpdir header Jan Stancek
2017-10-10 15:05 ` [LTP] [PATCH 3/6] safe_macros: add SAFE_SETENV() Jan Stancek
2017-10-10 15:05 ` [LTP] [PATCH 4/6] lib: extend PATH as part of test setup Jan Stancek
2017-10-10 15:18 ` Cyril Hrubis
2017-10-11 7:45 ` Jan Stancek [this message]
2017-10-11 8:00 ` Cyril Hrubis
2017-10-10 15:05 ` [LTP] [PATCH 5/6] creat07: no need to pass tst_ipc_envp anymore Jan Stancek
2017-10-12 8:08 ` Cyril Hrubis
2017-10-12 8:47 ` Li Wang
2017-10-12 8:50 ` Jan Stancek
2017-10-12 9:34 ` Jan Stancek
2017-10-10 15:05 ` [LTP] [PATCH 6/6] lib: drop tst_ipc_envp Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402903291.28351700.1507707959540.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox