* [LTP] [PATCH v4] fw_load: new test of device firmware loading
@ 2013-06-20 12:31 Alexey Kodanev
2013-06-20 13:29 ` Jan Stancek
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Kodanev @ 2013-06-20 12:31 UTC (permalink / raw)
To: ltp-list; +Cc: vasily.isaenko, Alexey Kodanev
This test checks the device firmware loading. Since Linux 3.7 it can be loaded
directly (by-pass udev). The test consists of the two parts: userspace and
kernelspace.
Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
---
runtest/syscalls | 2 +
testcases/kernel/Makefile | 1 +
testcases/kernel/firmware/Makefile | 44 ++++
.../kernel/firmware/fw_load_kernel/.gitignore | 1 +
testcases/kernel/firmware/fw_load_kernel/Makefile | 37 ++++
testcases/kernel/firmware/fw_load_kernel/README | 16 ++
testcases/kernel/firmware/fw_load_kernel/fw_load.c | 173 +++++++++++++++
testcases/kernel/firmware/fw_load_user/.gitignore | 1 +
testcases/kernel/firmware/fw_load_user/Makefile | 20 ++
testcases/kernel/firmware/fw_load_user/README | 11 +
testcases/kernel/firmware/fw_load_user/fw_load.c | 219 ++++++++++++++++++++
11 files changed, 525 insertions(+), 0 deletions(-)
create mode 100644 testcases/kernel/firmware/Makefile
create mode 100644 testcases/kernel/firmware/fw_load_kernel/.gitignore
create mode 100644 testcases/kernel/firmware/fw_load_kernel/Makefile
create mode 100644 testcases/kernel/firmware/fw_load_kernel/README
create mode 100644 testcases/kernel/firmware/fw_load_kernel/fw_load.c
create mode 100644 testcases/kernel/firmware/fw_load_user/.gitignore
create mode 100644 testcases/kernel/firmware/fw_load_user/Makefile
create mode 100644 testcases/kernel/firmware/fw_load_user/README
create mode 100644 testcases/kernel/firmware/fw_load_user/fw_load.c
diff --git a/runtest/syscalls b/runtest/syscalls
index e6ce29c..c11379c 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -314,6 +314,8 @@ ftruncate04_64 ftruncate04.sh 64
#futimesat test cases
futimesat01 futimesat01
+fw_load fw_load
+
getcontext01 getcontext01
getcpu01 getcpu01
diff --git a/testcases/kernel/Makefile b/testcases/kernel/Makefile
index 4b4800d..256a574 100644
--- a/testcases/kernel/Makefile
+++ b/testcases/kernel/Makefile
@@ -38,6 +38,7 @@ ifneq ($(UCLINUX),1)
SUBDIRS += connectors \
containers \
controllers \
+ firmware \
fs \
hotplug \
io \
diff --git a/testcases/kernel/firmware/Makefile b/testcases/kernel/firmware/Makefile
new file mode 100644
index 0000000..59817f6
--- /dev/null
+++ b/testcases/kernel/firmware/Makefile
@@ -0,0 +1,44 @@
+# Copyright (c) 2013 Oracle and/or its affiliates. All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+
+top_srcdir ?= ../../..
+
+include $(top_srcdir)/include/mk/env_pre.mk
+
+SUBDIRS =
+REQ_VERSION_MAJOR = 3
+REQ_VERSION_PATCH = 7
+
+ifeq ($(MAKECMDGOALS),clean)
+PROCEED = 1
+endif
+
+ifeq ($(WITH_MODULES),yes)
+PROCEED ?= $(shell expr $(LINUX_VERSION_MAJOR) '>' $(REQ_VERSION_MAJOR))
+ifeq ($(PROCEED),0)
+PROCEED = $(shell expr $(LINUX_VERSION_MAJOR) '=' $(REQ_VERSION_MAJOR))
+ifeq ($(PROCEED),1)
+PROCEED = $(shell expr $(LINUX_VERSION_PATCH) '>=' $(REQ_VERSION_PATCH))
+endif
+endif
+endif
+
+ifeq ($(PROCEED),1)
+SUBDIRS += fw_load_kernel
+SUBDIRS += fw_load_user
+endif
+
+include $(top_srcdir)/include/mk/generic_trunk_target.mk
diff --git a/testcases/kernel/firmware/fw_load_kernel/.gitignore b/testcases/kernel/firmware/fw_load_kernel/.gitignore
new file mode 100644
index 0000000..fdb463d
--- /dev/null
+++ b/testcases/kernel/firmware/fw_load_kernel/.gitignore
@@ -0,0 +1 @@
+/fw_load.ko
diff --git a/testcases/kernel/firmware/fw_load_kernel/Makefile b/testcases/kernel/firmware/fw_load_kernel/Makefile
new file mode 100644
index 0000000..e8d12be
--- /dev/null
+++ b/testcases/kernel/firmware/fw_load_kernel/Makefile
@@ -0,0 +1,37 @@
+# Copyright (c) 2013 Oracle and/or its affiliates. All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+
+MODULE := fw_load
+
+ifneq ($(KERNELRELEASE),)
+
+obj-m := $(MODULE).o
+
+else
+
+top_srcdir ?= ../../../..
+include $(top_srcdir)/include/mk/env_pre.mk
+
+MAKE_TARGETS := $(MODULE).ko
+$(MODULE).ko:
+ -$(MAKE) -C $(LINUX_DIR) M=$(abs_srcdir)
+ -mv $(MODULE).ko $(MODULE).ko~
+ -$(MAKE) -C $(LINUX_DIR) M=$(abs_srcdir) clean
+ -mv $(MODULE).ko~ $(MODULE).ko
+
+include $(top_srcdir)/include/mk/generic_leaf_target.mk
+
+endif
diff --git a/testcases/kernel/firmware/fw_load_kernel/README b/testcases/kernel/firmware/fw_load_kernel/README
new file mode 100644
index 0000000..320d956
--- /dev/null
+++ b/testcases/kernel/firmware/fw_load_kernel/README
@@ -0,0 +1,16 @@
+The aim of the test is to check device firmware loading. Since kernel 3.7
+firmware loading changed to direct loading (by-pass udev). The test consists
+of the two parts:
+ - userspace part
+ - kernelspace part
+
+This is a kernel module, which is a part of the device firmware loading test.
+It allows to call request_firmware kernel function with specified parameters.
+Template firmware file name and expected firmware file's data size are passed
+as the insmod command line parameters. Then, the number of firmware test files
+should be written to sysfs file 'fwnum'. This write will initiate request
+firmware procedure. In the end, results can be read from 'result' device sysfs
+file. Also, some information regarding module loading, can be obtained by
+looking at kernel log file.
+
+It is automatically used by userspace part of the test.
diff --git a/testcases/kernel/firmware/fw_load_kernel/fw_load.c b/testcases/kernel/firmware/fw_load_kernel/fw_load.c
new file mode 100644
index 0000000..2da9517
--- /dev/null
+++ b/testcases/kernel/firmware/fw_load_kernel/fw_load.c
@@ -0,0 +1,173 @@
+/*
+ * Copyright (c) 2013 Oracle and/or its affiliates. All Rights Reserved.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it would be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+ *
+ * Author:
+ * Alexey Kodanev <alexey.kodanev@oracle.com>
+ *
+ * This module is trying to load external test firmware files (n#_load_tst.fw).
+ * In the end, it writes results to /sys/devices/fw_load/result file.
+ */
+
+#include <linux/module.h>
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/device.h>
+#include <linux/string.h>
+#include <linux/firmware.h>
+
+MODULE_LICENSE("GPL");
+MODULE_AUTHOR("Alexey Kodanev <alexey.kodanev@oracle.com>");
+MODULE_DESCRIPTION("This module is checking device firmware loading");
+
+#define TCID "fw_load"
+
+static char *fw_name = "load_tst.fw";
+static int fw_size = 0x1000;
+static int max_name = 64;
+static int fw;
+
+module_param(fw_name, charp, 0444);
+MODULE_PARM_DESC(fw_name, "Template firmware file name: n#_name");
+
+module_param(fw_size, int, 0444);
+MODULE_PARM_DESC(fw_size, "Firmware file size");
+
+/*
+ * bit mask for each test-case,
+ * if test is passed, bit will be set to 1
+ */
+static int test_result;
+
+/* read and print firmware data */
+static int fw_read(const u8 *data, size_t size);
+
+static void device_release(struct device *dev);
+
+static struct device tdev = {
+ .init_name = TCID,
+ .release = device_release,
+};
+
+static int try_request_fw(const char *name);
+
+/* print test result to sysfs file */
+static ssize_t sys_result(struct device *dev,
+ struct device_attribute *attr, char *buf);
+static DEVICE_ATTR(result, S_IRUSR, sys_result, NULL);
+
+/*
+ * get the number of firmware files and
+ * perform firmware requests
+ */
+static ssize_t sys_fwnum(struct device *dev,
+ struct device_attribute *attr, const char *buf, size_t count);
+static DEVICE_ATTR(fwnum, S_IWUSR, NULL, sys_fwnum);
+
+static int test_init(void)
+{
+ int err;
+
+ err = device_register(&tdev);
+ if (err) {
+ pr_err(TCID ": Unable to register device\n");
+ return err;
+ }
+ pr_info(TCID ": device registered\n");
+
+ err = device_create_file(&tdev, &dev_attr_result);
+ if (err != 0)
+ pr_info(TCID ": Can't create sysfs file 'result'\n");
+ err = device_create_file(&tdev, &dev_attr_fwnum);
+ if (err != 0)
+ pr_info(TCID ": Can't create sysfs file 'fwnum'\n");
+
+ return err;
+}
+
+static void test_exit(void)
+{
+ device_remove_file(&tdev, &dev_attr_result);
+ device_remove_file(&tdev, &dev_attr_fwnum);
+
+ device_unregister(&tdev);
+ pr_info(TCID ": module exited\n");
+}
+
+static void device_release(struct device *dev)
+{
+ pr_info(TCID ": device released\n");
+}
+
+static ssize_t sys_result(struct device *dev,
+ struct device_attribute *attr, char *buf)
+{
+ return scnprintf(buf, PAGE_SIZE, "%d\n", test_result);
+}
+
+static ssize_t sys_fwnum(struct device *dev,
+ struct device_attribute *attr, const char *buf, size_t count)
+{
+ int err, fw_num = 0;
+
+ sscanf(buf, "%d", &fw_num);
+ if (fw_num <= 0) {
+ pr_err(TCID ": Unexpected number of firmwares '%d'", fw_num);
+ return count;
+ }
+ for (fw = 0; fw < fw_num; ++fw) {
+ char name[max_name];
+ snprintf(name, max_name, "n%d_%s", fw, fw_name);
+ err = try_request_fw(name);
+ test_result |= (err == 0) << fw;
+ }
+ return count;
+}
+
+static int fw_read(const u8 *data, size_t size)
+{
+ size_t i;
+ pr_info(TCID ": Firmware has size '%d'\n", (unsigned int) size);
+ if (size != fw_size) {
+ pr_err(TCID ": Expected firmware size '%d'\n",
+ (unsigned int) fw_size);
+ return -1;
+ }
+ for (i = 0; i < size; ++i) {
+ if (data[i] != (u8)fw) {
+ pr_err(TCID ": Unexpected firmware data\n");
+ return -1;
+ }
+ }
+ return 0;
+}
+
+static int try_request_fw(const char *name)
+{
+ int err;
+ const struct firmware *fw_entry = NULL;
+ err = request_firmware(&fw_entry, name, &tdev);
+ if (!err) {
+ pr_info(TCID ": firmware '%s' requested\n", name);
+ err = fw_read(fw_entry->data, fw_entry->size);
+ } else
+ pr_err(TCID ": Can't request firmware '%s'\n", name);
+ release_firmware(fw_entry);
+ return err;
+}
+
+module_init(test_init);
+module_exit(test_exit);
diff --git a/testcases/kernel/firmware/fw_load_user/.gitignore b/testcases/kernel/firmware/fw_load_user/.gitignore
new file mode 100644
index 0000000..1d08149
--- /dev/null
+++ b/testcases/kernel/firmware/fw_load_user/.gitignore
@@ -0,0 +1 @@
+/fw_load
diff --git a/testcases/kernel/firmware/fw_load_user/Makefile b/testcases/kernel/firmware/fw_load_user/Makefile
new file mode 100644
index 0000000..effd5da
--- /dev/null
+++ b/testcases/kernel/firmware/fw_load_user/Makefile
@@ -0,0 +1,20 @@
+# Copyright (c) 2013 Oracle and/or its affiliates. All Rights Reserved.
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License as
+# published by the Free Software Foundation; either version 2 of
+# the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it would be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write the Free Software Foundation,
+# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+
+top_srcdir ?= ../../../..
+
+include $(top_srcdir)/include/mk/testcases.mk
+include $(top_srcdir)/include/mk/generic_leaf_target.mk
diff --git a/testcases/kernel/firmware/fw_load_user/README b/testcases/kernel/firmware/fw_load_user/README
new file mode 100644
index 0000000..702fac9
--- /dev/null
+++ b/testcases/kernel/firmware/fw_load_user/README
@@ -0,0 +1,11 @@
+The aim of the test is to check device firmware loading. Since kernel 3.7
+firmware loading changed to direct loading (by-pass udev). The test consists
+of the two parts:
+ - userspace part
+ - kernelspace part
+
+This is the userspace part, its tasks are:
+ - create firmware files in the standard firmware paths
+ - load the module and initiate firmware request procedure
+ - read device's result file and print final results
+ - unload the module.
diff --git a/testcases/kernel/firmware/fw_load_user/fw_load.c b/testcases/kernel/firmware/fw_load_user/fw_load.c
new file mode 100644
index 0000000..5654862
--- /dev/null
+++ b/testcases/kernel/firmware/fw_load_user/fw_load.c
@@ -0,0 +1,219 @@
+/*
+ * Copyright (c) 2013 Oracle and/or its affiliates. All Rights Reserved.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it would be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+ *
+ * Author:
+ * Alexey Kodanev <alexey.kodanev@oracle.com>
+ *
+ * Test checks device firmware loading.
+ */
+
+#include <sys/utsname.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "test.h"
+#include "usctest.h"
+#include "safe_macros.h"
+#include "tst_module.h"
+
+/* number of test firmware files */
+#define FW_FILES 5
+
+char *TCID = "fw_load";
+int TST_TOTAL = FW_FILES;
+
+#define MAX_CMD_LEN 256
+/* hard coded paths in the kernel */
+#define FW_PATHS_NUM 4
+
+static int fw_size = 0x1000;
+
+static const char fw_name[] = "load_tst.fw";
+static const char module_name[] = "fw_load.ko";
+
+/* paths to module's sysfs files */
+static const char dev_fwnum[] = "/sys/devices/fw_load/fwnum";
+static const char dev_result[] = "/sys/devices/fw_load/result";
+
+
+struct fw_file_info {
+ char file[PATH_MAX];
+ char dir[PATH_MAX];
+ int fake;
+ int remove_dir;
+ int remove_file;
+};
+
+static struct fw_file_info fw[FW_FILES];
+static int fw_num;
+
+/* related firmware paths which are searched by kernel */
+static char fw_paths[FW_PATHS_NUM][PATH_MAX];
+
+/* test options */
+static char *narg;
+static int nflag;
+static int skip_cleanup;
+static int verbose;
+static const option_t options[] = {
+ {"n:", &nflag, &narg},
+ {"s", &skip_cleanup, NULL},
+ {"v", &verbose, NULL},
+ {NULL, NULL, NULL}
+};
+
+static void help(void);
+static void setup(int argc, char *argv[]);
+static void test_run(void);
+static void cleanup(void);
+
+/*
+ * create firmware files in the fw_paths
+ * @path: start directory
+ */
+static void create_firmware(const char *path);
+
+int main(int argc, char *argv[])
+{
+ setup(argc, argv);
+
+ test_run();
+
+ cleanup();
+
+ tst_exit();
+}
+
+static void help(void)
+{
+ printf(" -n x Write x bytes to firmware file, default is %d\n",
+ fw_size);
+ printf(" -s Skip cleanup\n");
+ printf(" -v Verbose\n");
+}
+
+void setup(int argc, char *argv[])
+{
+ char *msg;
+ msg = parse_opts(argc, argv, options, help);
+ if (msg != NULL)
+ tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
+
+ if (nflag) {
+ if (sscanf(narg, "%i", &fw_size) != 1)
+ tst_brkm(TBROK, NULL, "-n option arg is not a number");
+ if (fw_size < 0)
+ tst_brkm(TBROK, NULL, "-n option arg is less than 0");
+ }
+
+ tst_require_root(NULL);
+
+ if (tst_kvercmp(3, 7, 0) < 0) {
+ tst_brkm(TCONF, NULL,
+ "Test must be run with kernel 3.7 or newer");
+ }
+
+ tst_module_load(NULL, module_name, "fw_size=%d", fw_size);
+
+ tst_sig(FORK, DEF_HANDLER, cleanup);
+
+ /* get current Linux version and make firmware paths */
+ struct utsname uts_name;
+ uname(&uts_name);
+ strcpy(fw_paths[0], "firmware");
+ strcpy(fw_paths[1], "firmware/updates");
+ snprintf(fw_paths[2], PATH_MAX, "firmware/%s", uts_name.release);
+ snprintf(fw_paths[3], PATH_MAX, "firmware/updates/%s",
+ uts_name.release);
+
+ /* copy firmware to hard coded firmware search paths */
+ create_firmware("/lib");
+
+ /* make non-existent firmware file */
+ snprintf(fw[fw_num].file, PATH_MAX, "n%d_%s", fw_num, fw_name);
+ fw[fw_num].fake = 1;
+ ++fw_num;
+}
+
+static void test_run(void)
+{
+ /* initiate firmware requests */
+ SAFE_FILE_PRINTF(cleanup, dev_fwnum, "%d", fw_num);
+
+ /* get module results by reading result bit mask */
+ int result = 0;
+ SAFE_FILE_SCANF(cleanup, dev_result, "%d", &result);
+
+ int i, fail;
+ for (i = 0; i < fw_num; ++i) {
+ fail = (result & (1 << i)) == 0 && !fw[i].fake;
+
+ tst_resm((fail) ? TFAIL : TPASS,
+ "Expect: %s load firmware '...%s'",
+ (fw[i].fake) ? "can't" : "can",
+ fw[i].file + strlen(fw[i].dir));
+ }
+}
+
+static void cleanup(void)
+{
+ if (skip_cleanup)
+ return;
+
+ int i;
+ /* remove subdirs first and then upper level dirs */
+ for (i = fw_num - 1; i >= 0; --i) {
+ if (fw[i].remove_file && remove(fw[i].file) == -1)
+ tst_resm(TWARN, "Can't remove: %s", fw[i].file);
+
+ if (fw[i].remove_dir && remove(fw[i].dir) == -1)
+ tst_resm(TWARN, "Can't remove %s", fw[i].dir);
+ }
+
+ tst_module_unload(NULL, module_name);
+
+ TEST_CLEANUP;
+}
+
+static void create_firmware(const char *path)
+{
+ int i;
+ for (i = 0; i < ARRAY_SIZE(fw_paths); ++i) {
+ struct fw_file_info *fi = &fw[fw_num];
+ snprintf(fi->dir, PATH_MAX, "%s/%s", path, fw_paths[i]);
+ if (access(fi->dir, X_OK) == -1) {
+ /* create dir */
+ SAFE_MKDIR(cleanup, fi->dir, 0755);
+ fi->remove_dir = 1;
+ }
+
+ /* create test firmware file */
+ snprintf(fi->file, PATH_MAX, "%s/n%d_%s",
+ fi->dir, fw_num, fw_name);
+
+ FILE *f = SAFE_FOPEN(cleanup, fi->file, "w");
+ if (f == NULL)
+ tst_brkm(TBROK, cleanup, "Failed to create firmware");
+ int k;
+ for (k = 0; k < fw_size; ++k)
+ fputc(fw_num, f);
+ SAFE_FCLOSE(cleanup, f);
+
+ fi->remove_file = 1;
+ ++fw_num;
+ }
+}
--
1.7.1
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [LTP] [PATCH v4] fw_load: new test of device firmware loading
2013-06-20 12:31 [LTP] [PATCH v4] fw_load: new test of device firmware loading Alexey Kodanev
@ 2013-06-20 13:29 ` Jan Stancek
2013-06-20 14:38 ` alexey.kodanev
0 siblings, 1 reply; 3+ messages in thread
From: Jan Stancek @ 2013-06-20 13:29 UTC (permalink / raw)
To: Alexey Kodanev; +Cc: vasily isaenko, ltp-list
----- Original Message -----
> From: "Alexey Kodanev" <alexey.kodanev@oracle.com>
> To: ltp-list@lists.sourceforge.net
> Cc: "vasily isaenko" <vasily.isaenko@oracle.com>, "Alexey Kodanev" <alexey.kodanev@oracle.com>
> Sent: Thursday, 20 June, 2013 2:31:43 PM
> Subject: [LTP] [PATCH v4] fw_load: new test of device firmware loading
>
> This test checks the device firmware loading. Since Linux 3.7 it can be
> loaded
> directly (by-pass udev). The test consists of the two parts: userspace and
> kernelspace.
>
> Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
Hi,
looks good to me. I ran it with 3.10-rc4 and 2.6.18 kernel, worked as expected.
This included:
[PATCH v3] configure: add configure checks to compile kernel modules
[PATCH] tst_module: create new library functions for kernel modules
[PATCH v4] fw_load: new test of device firmware loading
I have one small suggestion, likely not worthy of making v5 just for this.
We could apply it on top later:
--- testcases/kernel/firmware/fw_load_kernel/Makefile 2013-06-20 15:08:19.339046672 +0200
+++ /tmp/Makefile 2013-06-20 15:11:50.876602284 +0200
@@ -18,7 +18,9 @@
ifneq ($(KERNELRELEASE),)
+ifdef CONFIG_FW_LOADER
obj-m := $(MODULE).o
+endif
else
@@ -26,7 +28,7 @@
include $(top_srcdir)/include/mk/env_pre.mk
MAKE_TARGETS := $(MODULE).ko
-$(MODULE).ko:
+$(MODULE).ko: fw_load.c
-$(MAKE) -C $(LINUX_DIR) M=$(abs_srcdir)
-mv $(MODULE).ko $(MODULE).ko~
-$(MAKE) -C $(LINUX_DIR) M=$(abs_srcdir) clean
Regards,
Jan
> ---
> runtest/syscalls | 2 +
> testcases/kernel/Makefile | 1 +
> testcases/kernel/firmware/Makefile | 44 ++++
> .../kernel/firmware/fw_load_kernel/.gitignore | 1 +
> testcases/kernel/firmware/fw_load_kernel/Makefile | 37 ++++
> testcases/kernel/firmware/fw_load_kernel/README | 16 ++
> testcases/kernel/firmware/fw_load_kernel/fw_load.c | 173 +++++++++++++++
> testcases/kernel/firmware/fw_load_user/.gitignore | 1 +
> testcases/kernel/firmware/fw_load_user/Makefile | 20 ++
> testcases/kernel/firmware/fw_load_user/README | 11 +
> testcases/kernel/firmware/fw_load_user/fw_load.c | 219
> ++++++++++++++++++++
> 11 files changed, 525 insertions(+), 0 deletions(-)
> create mode 100644 testcases/kernel/firmware/Makefile
> create mode 100644 testcases/kernel/firmware/fw_load_kernel/.gitignore
> create mode 100644 testcases/kernel/firmware/fw_load_kernel/Makefile
> create mode 100644 testcases/kernel/firmware/fw_load_kernel/README
> create mode 100644 testcases/kernel/firmware/fw_load_kernel/fw_load.c
> create mode 100644 testcases/kernel/firmware/fw_load_user/.gitignore
> create mode 100644 testcases/kernel/firmware/fw_load_user/Makefile
> create mode 100644 testcases/kernel/firmware/fw_load_user/README
> create mode 100644 testcases/kernel/firmware/fw_load_user/fw_load.c
>
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH v4] fw_load: new test of device firmware loading
2013-06-20 13:29 ` Jan Stancek
@ 2013-06-20 14:38 ` alexey.kodanev
0 siblings, 0 replies; 3+ messages in thread
From: alexey.kodanev @ 2013-06-20 14:38 UTC (permalink / raw)
To: Jan Stancek; +Cc: vasily isaenko, ltp-list
Hi!
On 06/20/2013 05:29 PM, Jan Stancek wrote:
>
> Hi,
>
> looks good to me. I ran it with 3.10-rc4 and 2.6.18 kernel, worked as expected.
> This included:
> [PATCH v3] configure: add configure checks to compile kernel modules
> [PATCH] tst_module: create new library functions for kernel modules
> [PATCH v4] fw_load: new test of device firmware loading
>
> I have one small suggestion, likely not worthy of making v5 just for this.
> We could apply it on top later:
>
> --- testcases/kernel/firmware/fw_load_kernel/Makefile 2013-06-20 15:08:19.339046672 +0200
> +++ /tmp/Makefile 2013-06-20 15:11:50.876602284 +0200
> @@ -18,7 +18,9 @@
>
> ifneq ($(KERNELRELEASE),)
>
> +ifdef CONFIG_FW_LOADER
> obj-m := $(MODULE).o
> +endif
>
I see, firmware loading/release functions works only with this config.
> else
>
> @@ -26,7 +28,7 @@
> include $(top_srcdir)/include/mk/env_pre.mk
>
> MAKE_TARGETS := $(MODULE).ko
> -$(MODULE).ko:
> +$(MODULE).ko: fw_load.c
> -$(MAKE) -C $(LINUX_DIR) M=$(abs_srcdir)
> -mv $(MODULE).ko $(MODULE).ko~
> -$(MAKE) -C $(LINUX_DIR) M=$(abs_srcdir) clean
>
OK
Thanks,
Alexey
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-20 14:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-20 12:31 [LTP] [PATCH v4] fw_load: new test of device firmware loading Alexey Kodanev
2013-06-20 13:29 ` Jan Stancek
2013-06-20 14:38 ` alexey.kodanev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox