From: Jan Stancek <jstancek@redhat.com>
To: Jeffrey Bastian <jbastian@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] fix glb_run type for disktest
Date: Thu, 30 Jan 2014 05:35:56 -0500 (EST) [thread overview]
Message-ID: <1421375175.1655489.1391078156014.JavaMail.root@redhat.com> (raw)
In-Reply-To: <20140129224307.GL30688@tarantula.localdomain>
----- Original Message -----
> From: "Jeffrey Bastian" <jbastian@redhat.com>
> To: ltp-list@lists.sourceforge.net
> Sent: Wednesday, 29 January, 2014 11:43:07 PM
> Subject: [LTP] [PATCH] fix glb_run type for disktest
>
> disktest/main.c and disktest/timer.c fail to compile on certain
> platforms due to mismatch in types -- short vs long -- with a
> gcc error "relocation truncated to fit"
>
> Thanks to Kyle McMartin for the hint on how to fix the error!
> ---
Hi Jeff,
pushed with added "Signed-off-by" line.
Regards,
Jan
> testcases/kernel/io/disktest/main.c | 2 +-
> testcases/kernel/io/disktest/timer.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/io/disktest/main.c
> b/testcases/kernel/io/disktest/main.c
> index 5e5b91a37a12..9484ec103601 100644
> --- a/testcases/kernel/io/disktest/main.c
> +++ b/testcases/kernel/io/disktest/main.c
> @@ -290,7 +290,7 @@ void *threadedMain(void *vtest)
> int i;
> unsigned char *sharedMem;
>
> - extern unsigned long glb_run;
> + extern unsigned short glb_run;
> extern int signal_action;
>
> test->args->pid = GETPID();
> diff --git a/testcases/kernel/io/disktest/timer.c
> b/testcases/kernel/io/disktest/timer.c
> index 45ae09f17b38..f47fa7dde496 100644
> --- a/testcases/kernel/io/disktest/timer.c
> +++ b/testcases/kernel/io/disktest/timer.c
> @@ -86,7 +86,7 @@ void *ChildTimer(void *vtest)
> test_env_t *env = test->env;
>
> extern int signal_action;
> - extern unsigned long glb_run;
> + extern unsigned short glb_run;
>
> #ifdef _DEBUG
> PDBG3(DBUG, args, "In timer %lu, %d\n", time(NULL), env->bContinue);
> --
> 1.8.3.1
>
>
> ------------------------------------------------------------------------------
> WatchGuard Dimension instantly turns raw network data into actionable
> security intelligence. It gives you real-time visual feedback on key
> security issues and trends. Skip the complicated setup - simply import
> a virtual appliance and go from zero to informed in seconds.
> http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
WatchGuard Dimension instantly turns raw network data into actionable
security intelligence. It gives you real-time visual feedback on key
security issues and trends. Skip the complicated setup - simply import
a virtual appliance and go from zero to informed in seconds.
http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
prev parent reply other threads:[~2014-01-30 10:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 22:43 [LTP] [PATCH] fix glb_run type for disktest Jeffrey Bastian
2014-01-30 10:35 ` Jan Stancek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421375175.1655489.1391078156014.JavaMail.root@redhat.com \
--to=jstancek@redhat.com \
--cc=jbastian@redhat.com \
--cc=ltp-list@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox