public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Zeng Linggang <zenglg.jy@cn.fujitsu.com>
To: Alexey Kodanev <alexey.kodanev@oracle.com>
Cc: ltp-list@lists.sourceforge.net, vasily.isaenko@oracle.com
Subject: [LTP] [PATCH] fallocate04: Use tst_kvercmp after lseek(SEEK_HOLE) return EINVAL
Date: Thu, 21 May 2015 13:39:37 +0800	[thread overview]
Message-ID: <1432186777.16347.56.camel@G08FNSTD140232> (raw)
In-Reply-To: <1429621507-23503-1-git-send-email-alexey.kodanev@oracle.com>

SEEK_HOLE is only supported since version 3.1. Just print some
information to remind users if kernel is before 3.1, if not print
'TBROK' and quit, instead of 'TWARN'.

Signed-off-by: Zeng Linggang <zenglg.jy@cn.fujitsu.com>
Signed-off-by: Jan Stancek <jstancek@redhat.com>
Signed-off-by: Alexey Kodanev <alexey.kodanev@oracle.com>
---
 testcases/kernel/syscalls/fallocate/fallocate04.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/testcases/kernel/syscalls/fallocate/fallocate04.c b/testcases/kernel/syscalls/fallocate/fallocate04.c
index 911bbe8..0c904a0 100644
--- a/testcases/kernel/syscalls/fallocate/fallocate04.c
+++ b/testcases/kernel/syscalls/fallocate/fallocate04.c
@@ -158,9 +158,15 @@ static void test02(void)
 			tst_brkm(TFAIL | TERRNO, cleanup,
 				 "fallocate() or lseek() failed");
 		}
-		tst_resm(TWARN | TERRNO, "lseek() doesn't support SEEK_HOLE");
+		if (tst_kvercmp(3, 1, 0) < 0)
+			tst_resm(TINFO, "lseek() doesn't support SEEK_HOLE, "
+				 "this is expected for < 3.1 kernels");
+		else
+			tst_brkm(TBROK | TERRNO, cleanup,
+				 "lseek() doesn't support SEEK_HOLE");
+	} else {
+		tst_resm(TINFO, "found a hole at '%ld' offset", ret);
 	}
-	tst_resm(TINFO, "found a hole at '%ld' offset", ret);
 
 	size_t alloc_size1 = get_allocsize();
 
-- 
1.9.3




------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  parent reply	other threads:[~2015-05-21  5:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21 13:05 [LTP] [PATCH v4] syscalls/fallocate04: add new fallocate() test Alexey Kodanev
2015-04-23  7:44 ` Jan Stancek
2015-04-27 14:07 ` Cyril Hrubis
     [not found]   ` <553E55D3.7070001@oracle.com>
2015-04-27 15:27     ` Cyril Hrubis
2015-05-18 10:14 ` [LTP] [PATCH] fallocate04: another check if SEEK_HOLE is not supported Zeng Linggang
2015-05-18 14:03   ` Alexey Kodanev
2015-05-19  8:50     ` [LTP] [PATCH v2] " Zeng Linggang
2015-05-19 11:18       ` Jan Stancek
2015-05-20  1:47         ` Zeng Linggang
2015-05-20  6:52           ` Jan Stancek
2015-05-20  9:58             ` Zeng Linggang
2015-05-20 11:32               ` Jan Stancek
2015-05-21  1:26                 ` Zeng Linggang
2015-05-20  8:13           ` Alexey Kodanev
2015-05-20  9:35             ` Zeng Linggang
2015-05-21  5:39 ` Zeng Linggang [this message]
2015-05-22 14:21   ` [LTP] [PATCH] fallocate04: Use tst_kvercmp after lseek(SEEK_HOLE) return EINVAL Jan Stancek
2015-06-04 11:35     ` Alexey Kodanev
2015-06-04 11:52       ` Jan Stancek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432186777.16347.56.camel@G08FNSTD140232 \
    --to=zenglg.jy@cn.fujitsu.com \
    --cc=alexey.kodanev@oracle.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=vasily.isaenko@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox