From: Wei, Jiangang <weijg.fnst@cn.fujitsu.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/2] kernel/io/disktest: cleanup upon failure occurs
Date: Wed, 25 Nov 2015 01:27:26 +0000 [thread overview]
Message-ID: <1448414844.1818.5.camel@localhost> (raw)
In-Reply-To: <20151124140853.GB4151@rei.lan>
On Tue, 2015-11-24 at 15:08 +0100, Cyril Hrubis wrote:
> Hi!
> > pMsg(ERR, args, "%s: Error = %u\n", args->device,
> > GETLASTERROR());
> > + FREE(buff);
> > return (-1);
> > }
> >
> > TargetLBA = Seek(fd, args->start_lba * BLK_SIZE);
> > if (TargetLBA != (args->start_lba * (OFF_T) BLK_SIZE)) {
> > pMsg(ERR, args, "Could not seek to start position.\n");
> > + FREE(buf);
> ^
> Should be buff
>
> The code does not even compile after the change, can you please compile
> test your change to avoid typos like this one?
Ok, I will keep in mind your comment.
Thanks a lot.
>
> --
> Cyril Hrubis
> chrubis@suse.cz
>
--
This message has been scanned for viruses and
dangerous content by Fujitsu, and is believed to be clean.
next prev parent reply other threads:[~2015-11-25 1:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 6:08 [LTP] [PATCH 1/2] kernel/io/disktest: cleanup upon failure occurs Wei Jiangang
2015-11-24 6:08 ` [LTP] [PATCH 2/2] Fix the order between 2>&1 and >/dev/null Wei Jiangang
2015-11-24 6:21 ` [LTP] [PATCH v2 1/2] kernel/io/disktest: cleanup upon failure occurs Wei Jiangang
2015-11-24 6:21 ` [LTP] [PATCH v2 2/2] Fix the order between 2>&1 and >/dev/null Wei Jiangang
2015-11-24 14:10 ` Cyril Hrubis
2015-11-25 1:25 ` Wei, Jiangang
2015-11-25 1:34 ` [LTP] [PATCH v3 1/2] kernel/io/disktest: cleanup upon failure occurs Wei Jiangang
2015-11-25 1:34 ` [LTP] [PATCH v3 2/2] fix the redirection order Wei Jiangang
2015-11-26 12:43 ` Cyril Hrubis
2015-11-24 14:08 ` [LTP] [PATCH v2 1/2] kernel/io/disktest: cleanup upon failure occurs Cyril Hrubis
2015-11-25 1:27 ` Wei, Jiangang [this message]
2015-11-24 6:19 ` [LTP] [PATCH " Wei, Jiangang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448414844.1818.5.camel@localhost \
--to=weijg.fnst@cn.fujitsu.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox