public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Steve Ellcey <sellcey@caviumnetworks.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] Remove unneeded time() declaration.
Date: Wed, 01 Mar 2017 09:26:21 -0800	[thread overview]
Message-ID: <1488389181.2866.256.camel@caviumnetworks.com> (raw)
In-Reply-To: <20170301124620.GA32207@rei.lan>

On Wed, 2017-03-01 at 13:46 +0100, Cyril Hrubis wrote:
> Hi!
> > 
> > The 'extern long time()' declaration conflicts with time.h which
> > declares time() to be of type time_t which may or may not be long.
> > This declaration causes a build failure on x86_64 if the file is
> > compiled with the -mx32 flag.  The time() function does not appear
> > to be used anywhere in fcntl14 so I am not sure why the declaration
> > is there anyway.
> This is obviously correct, but the patch misses the Signed-of-by:
> line.
> 
> Also usually the first line of the patch describes what testcase it
> fixes so it should have been something like:
> 
> syscalls/fcntl14: Remove unneeded time() declaration.
> 
> Can you please resend with fixed commit description?

I updated the comments and resent the patch using format-patch and
send-email.  I am not sure if that is the right way to do it but I
don't see any way to use format-patch/send-email to resend the patch as
a response to your email so I sent it as a new email/thread.  The
inability (as far as I know) to update the patch and send it as a
response to an existing email thread is one of the reasons I am not a
huge fan of those tools but if that is how you want it done, I will do
it that way.

Steve Ellcey

  reply	other threads:[~2017-03-01 17:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-28 21:35 [LTP] [PATCH] Remove unneeded time() declaration Steve Ellcey
2017-03-01 12:46 ` Cyril Hrubis
2017-03-01 17:26   ` Steve Ellcey [this message]
2017-03-02 12:41     ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488389181.2866.256.camel@caviumnetworks.com \
    --to=sellcey@caviumnetworks.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox