public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] syscalls/ioctl09: Add test for BLKRRPART ioctl
Date: Tue, 7 Jul 2020 09:40:46 -0400 (EDT)	[thread overview]
Message-ID: <150668383.1091545.1594129246387.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1594016612-7975-1-git-send-email-xuyang2018.jy@cn.fujitsu.com>



----- Original Message -----

Hi,

> +static void verify_ioctl(void)
> +{
> +	const char *const cmd_parted_old[] = {"parted", "-s", "test.img",
> "mklabel", "msdos", "mkpart",
> +						"primary", "ext4", "1M", "10M", NULL};
> +	const char *const cmd_parted_new[] = {"parted", "-s", "test.img",
> "mklabel", "msdos", "mkpart",
> +						"primary", "ext4", "1M", "10M", "mkpart", "primary", "ext4", "10M",
> "20M", NULL};

^^ These (and other lines) goe way over 80 characters.

> +	struct loop_info loopinfo = {0};
> +
> +	dev_num = tst_find_free_loopdev(dev_path, sizeof(dev_path));
> +	if (dev_num < 0)
> +		tst_brk(TBROK, "Failed to find free loop device");
> +
> +	tst_fill_file("test.img", 0, 1024 * 1024, 20);

20MB feels a bit small, even though tests I ran passed on old and new kernels.
LTP default is 256, to cover various filesystems, but here we don't even
write anything..

Other than that, it looks good to me:
Acked-by: Jan Stancek <jstancek@redhat.com>


  reply	other threads:[~2020-07-07 13:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-06  6:23 [LTP] [PATCH] syscalls/ioctl09: Add test for BLKRRPART ioctl Yang Xu
2020-07-07 13:40 ` Jan Stancek [this message]
2020-07-08  2:06   ` Yang Xu
2020-07-08  5:46     ` Jan Stancek
2020-07-08  6:06       ` [LTP] [PATCH v2] syscalls/ioctl09: Add test for BLKRRPART ioctl " Yang Xu
2020-07-16  1:28         ` Yang Xu
2020-07-20 14:56         ` Cyril Hrubis
2020-07-21  2:14           ` Yang Xu
2020-07-21  2:26           ` [LTP] [PATCH v3] " Yang Xu
2020-07-22  8:28             ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=150668383.1091545.1594129246387.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox