public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] syscalls/mprotect: align exec_func to 64 bytes
Date: Mon, 25 Feb 2019 02:37:50 -0500 (EST)	[thread overview]
Message-ID: <1508347197.2635651.1551080270164.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAEemH2f6=VqWp7f=2VrFQPN_7BfTv7H4J-r5CdFcPE5xTXOLQg@mail.gmail.com>




----- Original Message -----
> On Tue, Feb 12, 2019 at 6:15 AM Jan Stancek <jstancek@redhat.com> wrote:
> 
> > exec_func() is dummy/empty function. Try to align it so we don't
> > need to worry about copying 2 pages. But also check that compiler
> > aligned it and there's sufficient space between start of func_exec
> > and end of page.
> >
> > This patch also removes copy_sz, which is now replaced with page_sz.
> >
> > Signed-off-by: Jan Stancek <jstancek@redhat.com>
> >
> 
> Reviewed-by: Li Wang <liwang@redhat.com>

Pushed.

Regards,
Jan

> 
> 
> > +mprotect04: CFLAGS += -falign-functions=64
> >
> 
> One of my concern was this option maybe not supported by kind of compiler
> and probably broken in the compiling phase. So I just submitted these
> two(another is Daniel's) patches to Travis CI, the result looks good and no
> compiler error found there.
> https://travis-ci.com/wangli5665/ltp/builds/101429714
> 
> Beside that, I also manually tried that with old gcc(gcc version 4.1.2) and
> verify that works fine.
> 
> --
> Regards,
> Li Wang
> 

      reply	other threads:[~2019-02-25  7:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-11 22:15 [LTP] [PATCH v2] syscalls/mprotect: align exec_func to 64 bytes Jan Stancek
2019-02-11 23:54 ` Daniel Mentz
2019-02-12  7:40   ` Jan Stancek
2019-02-19 13:29 ` Li Wang
2019-02-25  7:37   ` Jan Stancek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1508347197.2635651.1551080270164.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox